linux-kernel - Re: [PATCH V2] ath9k: Use platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 14 Mar 2022 10:05:57 +0200
From:   Kalle Valo <kvalo@...nel.org>
To:     cgel.zte@...il.com
Cc:     toke@...e.dk, davem@...emloft.net, kuba@...nel.org,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, Minghao Chi <chi.minghao@....com.cn>
Subject: Re: [PATCH V2] ath9k: Use platform_get_irq() to get the interrupt

Kalle Valo <kvalo@...nel.org> writes:

> cgel.zte@...il.com writes:
>
>> From: Minghao Chi <chi.minghao@....com.cn>
>>
>> It is not recommened to use platform_get_resource(pdev, IORESOURCE_IRQ)
>> for requesting IRQ's resources any more, as they can be not ready yet in
>> case of DT-booting.
>>
>> platform_get_irq() instead is a recommended way for getting IRQ even if
>> it was not retrieved earlier.
>>
>> It also makes code simpler because we're getting "int" value right away
>> and no conversion from resource to int is required.
>>
>> Reported-by: Zeal Robot <zealci@....com.cn>
>> Signed-off-by: Minghao Chi <chi.minghao@....com.cn>
>> ---
>> v1->v2:
>>   - Retain dev_err() call on failure
>>
>>  drivers/net/wireless/ath/ath9k/ahb.c | 8 +++-----
>>  1 file changed, 3 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/net/wireless/ath/ath9k/ahb.c b/drivers/net/wireless/ath/ath9k/ahb.c
>> index cdefb8e2daf1..28c45002c115 100644
>> --- a/drivers/net/wireless/ath/ath9k/ahb.c
>> +++ b/drivers/net/wireless/ath/ath9k/ahb.c
>> @@ -98,14 +98,12 @@ static int ath_ahb_probe(struct platform_device *pdev)
>>  		return -ENOMEM;
>>  	}
>>  
>> -	res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
>> -	if (res == NULL) {
>> +	irq = platform_get_resource(pdev, 0);
>
> Is this really correct? Should it be platform_get_irq()?
>
> Do you compile test your patches? That's mandatory.

Also please fix your email setup, I get an error for this address:

<zealci@....com.cn>: host mxde.zte.com.cn[209.9.37.26] said: 550 5.1.1 User
    unknown id=622EE16E.000 (in reply to RCPT TO command)

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches