[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <d13b7bb3-989c-55eb-c7b9-41836ccb95a9@collabora.com>
Date: Mon, 14 Mar 2022 11:44:58 +0100
From: AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com>
To: Jiaxin Yu <jiaxin.yu@...iatek.com>, broonie@...nel.org,
robh+dt@...nel.org
Cc: aaronyu@...gle.com, matthias.bgg@...il.com, trevor.wu@...iatek.com,
tzungbi@...gle.com, julianbraha@...il.com,
alsa-devel@...a-project.org, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
Project_Global_Chrome_Upstream_Group@...iatek.com
Subject: Re: [v3 15/19] ASoC: mediatek: mt8186: add machine driver with
mt6366, da7219 and max98357
Il 13/03/22 16:10, Jiaxin Yu ha scritto:
> Add support for mt8186 board with mt6366, da7219 and max98357.
>
> Signed-off-by: Jiaxin Yu <jiaxin.yu@...iatek.com>
> ---
> .../mt8186/mt8186-mt6366-da7219-max98357.c | 924 ++++++++++++++++++
> 1 file changed, 924 insertions(+)
> create mode 100644 sound/soc/mediatek/mt8186/mt8186-mt6366-da7219-max98357.c
>
Hello Jiaxin,
I see some duplication between this one and the mt6366-rt1019-rt5682s....
....for this reason, I would propose to split out the MT6366 bits into a
common file, something like mt8186-mt6366-common.c, as to reduce the duplication.
If it is expected to see MT8186 machines with DA7219 or MAX98357, then it'd be a
good idea to also do something about preventively commonizing these ones, like
it is being done in ... MT8192, if I remember correctly.
Regards,
Angelo
Powered by blists - more mailing lists