linux-kernel - Re: [PATCH V3 05/10] perf: Add PERF_BR_NEW_ARCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <29ab721c-10bd-68e7-a1e0-8564e60f7584@arm.com>
Date:   Mon, 14 Mar 2022 16:18:35 +0530
From:   Anshuman Khandual <anshuman.khandual@....com>
To:     kernel test robot <lkp@...el.com>, linux-kernel@...r.kernel.org,
        linux-perf-users@...r.kernel.org, peterz@...radead.org,
        acme@...nel.org
Cc:     kbuild-all@...ts.01.org, Suzuki Poulose <suzuki.poulose@....com>,
        James Clark <james.clark@....com>,
        Ingo Molnar <mingo@...hat.com>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Will Deacon <will@...nel.org>,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH V3 05/10] perf: Add PERF_BR_NEW_ARCH_[N] map for BRBE on
 arm64 platform



On 3/14/22 14:07, kernel test robot wrote:
>>> error: include/uapi/linux/perf_event.h: leak CONFIG_ARM64 to user-space
>    make[2]: *** [scripts/Makefile.headersinst:63: usr/include/linux/perf_event.h] Error 1
>    make[2]: Target '__headers' not remade because of errors.
>    make[1]: *** [Makefile:1277: headers] Error 2
>    make[1]: Target 'prepare' not remade because of errors.
>    make: *** [Makefile:219: __sub-make] Error 2
>    make: Target 'prepare' not remade because of errors.

I should have avoided CONFIG_ARM64 in the the header file which gets
duplicated for tools/include/.. Looking at this once again, platform
build wrappers are not really required for these arch overrides. These
arm64 branch types can co-exist with any other platform overrides when
they get added later on. Just that the branch type nomenclature should
include the platform name some where. Something like ..

PERF_BR_<ARCH>_<BRANCH_TYPE>

#define PERF_BR_ARM64_FIQ               PERF_BR_NEW_ARCH_1
#define PERF_BR_ARM64_DEBUG_HALT        PERF_BR_NEW_ARCH_2
#define PERF_BR_ARM64_DEBUG_EXIT        PERF_BR_NEW_ARCH_3
#define PERF_BR_ARM64_DEBUG_INST        PERF_BR_NEW_ARCH_4
#define PERF_BR_ARM64_DEBUG_DATA        PERF_BR_NEW_ARCH_5

Will do this change next time around.

- Anshuman