linux-kernel - Re: [PATCH] scsi: bsg: drop needless assignment in scsi_bsg_sg_io

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yq1ilsfay7h.fsf@ca-mkp.ca.oracle.com>
Date:   Tue, 15 Mar 2022 14:05:14 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Lukas Bulwahn <lukas.bulwahn@...il.com>
Cc:     Christoph Hellwig <hch@....de>,
        "Martin K . Petersen" <martin.petersen@...cle.com>,
        linux-scsi@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: bsg: drop needless assignment in scsi_bsg_sg_io_fn()


Lukas,

> Commit ce70fd9a551a ("scsi: core: Remove the cmd field from struct
> scsi_request") refactored scsi_bsg_sg_io_fn(), so that it does not
> allocate directly and hence does not return -ENOMEM in its error case.
> That makes a remaining assignment of -ENOMEM to the return variable
> needless.

Applied to 5.18/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering