linux-kernel - Re: [PATCH v3] pstore: Don't use semaphores in always-atomic-context code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <164736790118.3742734.9257736142357327917.b4-ty@chromium.org>
Date:   Tue, 15 Mar 2022 11:11:43 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Jann Horn <jannh@...gle.com>
Cc:     Kees Cook <keescook@...omium.org>,
        Ard Biesheuvel <ardb@...nel.org>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        stable@...r.kernel.org, Tony Luck <tony.luck@...el.com>,
        Anton Vorontsov <anton@...msg.org>, linux-efi@...r.kernel.org,
        Colin Cross <ccross@...roid.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] pstore: Don't use semaphores in always-atomic-context code

On Mon, 14 Mar 2022 19:59:53 +0100, Jann Horn wrote:
> pstore_dump() is *always* invoked in atomic context (nowadays in an RCU
> read-side critical section, before that under a spinlock).
> It doesn't make sense to try to use semaphores here.
> 
> This is mostly a revert of commit ea84b580b955 ("pstore: Convert buf_lock
> to semaphore"), except that two parts aren't restored back exactly as they
> were:
> 
> [...]

Applied to for-next/pstore, thanks!

[1/1] pstore: Don't use semaphores in always-atomic-context code
      https://git.kernel.org/kees/c/8126b1c73108

-- 
Kees Cook