[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <YjEVzF1NMWJZ1MQw@pendragon.ideasonboard.com>
Date: Wed, 16 Mar 2022 00:40:12 +0200
From: Laurent Pinchart <laurent.pinchart@...asonboard.com>
To: Jonathan Neuschäfer <j.neuschaefer@....net>
Cc: linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
Kieran Bingham <kieran.bingham@...asonboard.com>,
Mauro Carvalho Chehab <mchehab@...nel.org>
Subject: Re: [PATCH v2] docs: media: uvcvideo: Use linux-media mailing list
On Tue, Mar 15, 2022 at 11:25:43PM +0100, Jonathan Neuschäfer wrote:
> On Wed, Mar 16, 2022 at 12:18:55AM +0200, Laurent Pinchart wrote:
> > Hi Jonathan,
> >
> > Thank you for the patch.
> >
> > On Tue, Mar 15, 2022 at 11:10:06PM +0100, Jonathan Neuschäfer wrote:
> > > As discussed with other developers, the linux-uvc-devel mailing list is
> > > not very useful anymore, and it's better to send people to the general
> > > linux-media mailing list.
> > >
> > > Replace/remove the old mailing list address in uvcvideo.rst and
> > > MAINTAINERS.
> > >
> > > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@....net>
> > > ---
> > >
> > > v2:
> > > - Changed mailing list to linux-media@...r.kernel.org instead
> > >
> > > v1:
> > > - https://lore.kernel.org/lkml/20220312203323.626657-1-j.neuschaefer@gmx.net/
> > > ---
> > > Documentation/userspace-api/media/drivers/uvcvideo.rst | 2 +-
> > > MAINTAINERS | 1 -
> >
> > This looks good, but I think we should also add the following:
> >
> > diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
> > index 5f394d4efc21..6c6a82af07ce 100644
> > --- a/drivers/media/usb/uvc/uvc_driver.c
> > +++ b/drivers/media/usb/uvc/uvc_driver.c
> > @@ -2443,7 +2443,7 @@ static int uvc_probe(struct usb_interface *intf,
> > "Forcing device quirks to 0x%x by module parameter for testing purpose.\n",
> > dev->quirks);
> > dev_info(&dev->udev->dev,
> > - "Please report required quirks to the linux-uvc-devel mailing list.\n");
> > + "Please report required quirks to the linux-media mailing list.\n");
> > }
> >
> > if (dev->info->uvc_version) {
> >
> > If you're fine with that change, there's no need to resubmit, I can
> > handle this locally.
> >
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
>
> Ah, just before I saw your reply, I noticed this instance too, and sent
> a separate patch for it.
I'd say great minds think alike if it wasn't presumptuous :-)
> I'll leave it up to you to handle it as you wish, I'm fine with it
> either way.
I'll squash the two patches as they're closely related.
--
Regards,
Laurent Pinchart
Powered by blists - more mailing lists