linux-kernel - Re: [PATCH 07/16] clk: qcom: clk-krait: add hw_parent check for div2_round

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220315224338.BB736C340E8@smtp.kernel.org>
Date:   Tue, 15 Mar 2022 15:43:36 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Andy Gross <agross@...nel.org>,
        Ansuel Smith <ansuelsmth@...il.com>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Michael Turquette <mturquette@...libre.com>,
        Peter De Schrijver <pdeschrijver@...dia.com>,
        Prashant Gaikwad <pgaikwad@...dia.com>,
        Rob Herring <robh+dt@...nel.org>,
        Thierry Reding <thierry.reding@...il.com>,
        devicetree@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-tegra@...r.kernel.org
Subject: Re: [PATCH 07/16] clk: qcom: clk-krait: add hw_parent check for div2_round_rate

Quoting Ansuel Smith (2022-03-13 12:04:10)
> Check if hw_parent is present before calculating the round_rate to
> prevent kernel panic.
> 
> Signed-off-by: Ansuel Smith <ansuelsmth@...il.com>
> ---
>  drivers/clk/qcom/clk-krait.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/qcom/clk-krait.c b/drivers/clk/qcom/clk-krait.c
> index e447fcc3806d..d8af281eba0e 100644
> --- a/drivers/clk/qcom/clk-krait.c
> +++ b/drivers/clk/qcom/clk-krait.c
> @@ -80,7 +80,12 @@ EXPORT_SYMBOL_GPL(krait_mux_clk_ops);
>  static long krait_div2_round_rate(struct clk_hw *hw, unsigned long rate,
>                                   unsigned long *parent_rate)
>  {
> -       *parent_rate = clk_hw_round_rate(clk_hw_get_parent(hw), rate * 2);
> +       struct clk_hw *hw_parent = clk_hw_get_parent(hw);
> +
> +       if (!hw_parent)
> +               return -1;

Use -EINVAL or some proper error code, not just -1

> +
> +       *parent_rate = clk_hw_round_rate(hw_parent, rate * 2);
>         return DIV_ROUND_UP(*parent_rate, 2);
>  }
>  
> -- 
> 2.34.1
>