linux-kernel - Re: [PATCH 1/3] x86: Separate out x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f6f7efdf860fcf9bb117698bdc849f364d10b212.camel@intel.com>
Date:   Tue, 15 Mar 2022 23:33:31 +0000
From:   "Edgecombe, Rick P" <rick.p.edgecombe@...el.com>
To:     "ebiederm@...ssion.com" <ebiederm@...ssion.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "keescook@...omium.org" <keescook@...omium.org>,
        "viro@...iv.linux.org.uk" <viro@...iv.linux.org.uk>,
        "Williams, Dan J" <dan.j.williams@...el.com>,
        "Wysocki, Rafael J" <rafael.j.wysocki@...el.com>,
        "Chatre, Reinette" <reinette.chatre@...el.com>,
        "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
        "Luck, Tony" <tony.luck@...el.com>,
        "Hansen, Dave" <dave.hansen@...el.com>,
        "Brown, Len" <len.brown@...el.com>
Subject: Re: [PATCH 1/3] x86: Separate out x86_regset for 32 and 64 bit

On Tue, 2022-03-15 at 18:01 -0500, Eric W. Biederman wrote:
> So I am looking at this and am wondering if the enums should be:
> 
> enum x86_32_regset {
>         REGSET32_GENERAL,
>         REGSET32_FP,
>         REGSET32_XFP,
>         REGSET32_XSTATE,
>         REGSET32_TLS,
>         REGSET32_IOPERM32,
> };
> 
> enum x86_64_regset {
>         REGSET64_GENERAL,
>         REGSET64_FP,
>         REGSET64_IOPERM64,
>         REGSET64_XSTATE,
> };
> 
> 
> That is named in such a way that it emphasizes that the difference is
> the architecture.  Otherwise it reads like the difference is the size
> of
> the registers in the regset.  I am pretty certain that in your
> REGSET_FP32 and REGSET_FP64 all of the registers are 80 bits long.

Yes, that makes sense. I had just copied the format
of REGSET_IOPERM32/REGSET_IOPERM64, but I'll change it like you suggest
here.

Thanks,

Rick