linux-kernel - [PATCH for-5.18 v2] ASoC: atmel: mchp-pdmc: Fix `-Wpointer-bool-conversion` warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220315001848.3763534-1-alviro.iskandar@gnuweeb.org>
Date:   Tue, 15 Mar 2022 00:18:48 +0000
From:   Alviro Iskandar Setiawan <alviro.iskandar@...weeb.org>
To:     Mark Brown <broonie@...nel.org>
Cc:     Alviro Iskandar Setiawan <alviro.iskandar@...weeb.org>,
        Alviro Iskandar Setiawan <alviro.iskandar@...il.com>,
        Codrin Ciubotariu <codrin.ciubotariu@...rochip.com>,
        GNU/Weeb Mailing List <gwml@...r.gnuweeb.org>,
        kbuild-all@...ts.01.org, kernel test robot <lkp@...el.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        llvm@...ts.linux.dev, Nugraha <richiisei@...il.com>,
        Nathan Chancellor <nathan@...nel.org>
Subject: [PATCH for-5.18 v2] ASoC: atmel: mchp-pdmc: Fix `-Wpointer-bool-conversion` warning

In function mchp_pdmc_af_put(), Intel's kernel test robot reports the
following warning:

  sound/soc/atmel/mchp-pdmc.c:186:34: warning: address of array \
  'uvalue->value.integer.value' will always evaluate to 'true' \
  [-Wpointer-bool-conversion]

This is because we are using `uvalue->value.integer.value` which its
type is `long value[128];` for conditional expression and that array
will always decay to a non-NULL pointer. Using a non-NULL pointer for
conditional expression will always evaluate to true.

Fix this by changing it to `uvalue->value.integer.value[0]` as that's
what the mchp_pdmc_af_get() function sets.

Cc: Nugraha <richiisei@...il.com>
Reported-by: kernel test robot <lkp@...el.com>
Link: https://lore.kernel.org/lkml/202203091430.MLY27Bif-lkp@intel.com
Fixes: 50291652af52 ("ASoC: atmel: mchp-pdmc: add PDMC driver")
Link: https://lore.gnuweeb.org/gwml/20220309065849.96165-1-alviro.iskandar@gnuweeb.org # v1
Reviewed-by: Codrin Ciubotariu <codrin.ciubotariu@...rochip.com>
Reviewed-by: Nathan Chancellor <nathan@...nel.org>
Signed-off-by: Alviro Iskandar Setiawan <alviro.iskandar@...weeb.org>
---

  v1 -> v2:
    - Remove mailing list from the CC tags.
    - Append reviewed by tags from Nathan and Codrin.

 sound/soc/atmel/mchp-pdmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/atmel/mchp-pdmc.c b/sound/soc/atmel/mchp-pdmc.c
index c44636f6207d..7b87f75c284c 100644
--- a/sound/soc/atmel/mchp-pdmc.c
+++ b/sound/soc/atmel/mchp-pdmc.c
@@ -183,7 +183,7 @@ static int mchp_pdmc_af_put(struct snd_kcontrol *kcontrol,
 {
 	struct snd_soc_component *component = snd_kcontrol_chip(kcontrol);
 	struct mchp_pdmc *dd = snd_soc_component_get_drvdata(component);
-	bool af = uvalue->value.integer.value ? true : false;
+	bool af = uvalue->value.integer.value[0] ? true : false;
 
 	if (dd->audio_filter_en == af)
 		return 0;

base-commit: 50291652af5269813baa6024eb0e81b5f0bbb451
-- 
2.27.0