linux-kernel - Re: [PATCH 1/2] xen/grant-table: remove gnttab

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1633fb91-3771-e37c-14ce-43f1b0cda6a0@suse.com>
Date:   Tue, 15 Mar 2022 07:10:19 +0100
From:   Juergen Gross <jgross@...e.com>
To:     Boris Ostrovsky <boris.ostrovsky@...cle.com>,
        xen-devel@...ts.xenproject.org, linux-kernel@...r.kernel.org
Cc:     Stefano Stabellini <sstabellini@...nel.org>
Subject: Re: [PATCH 1/2] xen/grant-table: remove gnttab_*transfer*() functions

On 15.03.22 00:37, Boris Ostrovsky wrote:
> 
> On 3/11/22 5:34 AM, Juergen Gross wrote:
>> All grant table operations related to the "transfer" functionality
>> are unused currently. There have been users in the old days of the
>> "Xen-o-Linux" kernel, but those didn't make it upstream.
>>
>> So remove the "transfer" related functions.
> 
> 
> Do we need to assert somewhere that transfer flags are not set?

This would be an orthogonal change, right? My patch is just removing
never called functions.

In any case I believe checking those flags is the job of the hypervisor.
If an operation is illegal due to a transfer flag being set, it needs to
be rejected at hypervisor level.


Juergen

Download attachment "OpenPGP_0xB0DE9DD628BF132F.asc" of type "application/pgp-keys" (3099 bytes)

Download attachment "OpenPGP_signature" of type "application/pgp-signature" (496 bytes)