linux-kernel - [willy-pagecache:for-next 131/179] mm/readahead.c:54:3: error: implicit declaration of function 'do_invalidatepage'; did you mean 'noop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202203151544.J2Qcx5YQ-lkp@intel.com>
Date:   Tue, 15 Mar 2022 15:04:41 +0800
From:   kernel test robot <lkp@...el.com>
To:     "Matthew Wilcox (Oracle)" <willy@...radead.org>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: [willy-pagecache:for-next 131/179] mm/readahead.c:54:3: error:
 implicit declaration of function 'do_invalidatepage'; did you mean
 'noop_invalidatepage'?

tree:   git://git.infradead.org/users/willy/pagecache for-next
head:   af564d7369d44fbbe697a5f631fe3bba5ebecd59
commit: f1fdabbaae8eb5c9a95a3747065a40297e7d2736 [131/179] fs: Turn do_invalidatepage() into folio_invalidate()
config: um-x86_64_defconfig (https://download.01.org/0day-ci/archive/20220315/202203151544.J2Qcx5YQ-lkp@intel.com/config)
compiler: gcc-9 (Ubuntu 9.4.0-1ubuntu1~20.04) 9.4.0
reproduce (this is a W=1 build):
        git remote add willy-pagecache git://git.infradead.org/users/willy/pagecache
        git fetch --no-tags willy-pagecache for-next
        git checkout f1fdabbaae8eb5c9a95a3747065a40297e7d2736
        # save the config file to linux build tree
        mkdir build_dir
        make W=1 O=build_dir ARCH=um SUBARCH=x86_64 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   mm/readahead.c: In function 'read_cache_pages_invalidate_page':
>> mm/readahead.c:54:3: error: implicit declaration of function 'do_invalidatepage'; did you mean 'noop_invalidatepage'? [-Werror=implicit-function-declaration]
      54 |   do_invalidatepage(page, 0, PAGE_SIZE);
         |   ^~~~~~~~~~~~~~~~~
         |   noop_invalidatepage
   cc1: some warnings being treated as errors


vim +54 mm/readahead.c

^1da177e4c3f415 Linus Torvalds     2005-04-16  39  
03fb3d2af96c278 David Howells      2009-04-03  40  /*
03fb3d2af96c278 David Howells      2009-04-03  41   * see if a page needs releasing upon read_cache_pages() failure
266cf658efcf6ac David Howells      2009-04-03  42   * - the caller of read_cache_pages() may have set PG_private or PG_fscache
266cf658efcf6ac David Howells      2009-04-03  43   *   before calling, such as the NFS fs marking pages that are cached locally
266cf658efcf6ac David Howells      2009-04-03  44   *   on disk, thus we need to give the fs a chance to clean up in the event of
266cf658efcf6ac David Howells      2009-04-03  45   *   an error
03fb3d2af96c278 David Howells      2009-04-03  46   */
03fb3d2af96c278 David Howells      2009-04-03  47  static void read_cache_pages_invalidate_page(struct address_space *mapping,
03fb3d2af96c278 David Howells      2009-04-03  48  					     struct page *page)
03fb3d2af96c278 David Howells      2009-04-03  49  {
266cf658efcf6ac David Howells      2009-04-03  50  	if (page_has_private(page)) {
03fb3d2af96c278 David Howells      2009-04-03  51  		if (!trylock_page(page))
03fb3d2af96c278 David Howells      2009-04-03  52  			BUG();
03fb3d2af96c278 David Howells      2009-04-03  53  		page->mapping = mapping;
09cbfeaf1a5a67b Kirill A. Shutemov 2016-04-01 @54  		do_invalidatepage(page, 0, PAGE_SIZE);
03fb3d2af96c278 David Howells      2009-04-03  55  		page->mapping = NULL;
03fb3d2af96c278 David Howells      2009-04-03  56  		unlock_page(page);
03fb3d2af96c278 David Howells      2009-04-03  57  	}
09cbfeaf1a5a67b Kirill A. Shutemov 2016-04-01  58  	put_page(page);
03fb3d2af96c278 David Howells      2009-04-03  59  }
03fb3d2af96c278 David Howells      2009-04-03  60  

:::::: The code at line 54 was first introduced by commit
:::::: 09cbfeaf1a5a67bfb3201e0c83c810cecb2efa5a mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros

:::::: TO: Kirill A. Shutemov <kirill.shutemov@...ux.intel.com>
:::::: CC: Linus Torvalds <torvalds@...ux-foundation.org>

---
0-DAY CI Kernel Test Service
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org