linux-kernel - Re: [PATCH v0] pata_parport: add driver (PARIDE replacement)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220315082301.GA3502@lst.de>
Date:   Tue, 15 Mar 2022 09:23:01 +0100
From:   Christoph Hellwig <hch@....de>
To:     Ondrej Zary <linux@...y.sk>
Cc:     Damien Le Moal <damien.lemoal@...nsource.wdc.com>,
        Christoph Hellwig <hch@....de>, Jens Axboe <axboe@...nel.dk>,
        Tim Waugh <tim@...erelk.net>, linux-block@...r.kernel.org,
        linux-parport@...ts.infradead.org, linux-ide@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v0] pata_parport: add driver (PARIDE replacement)

On Sat, Mar 12, 2022 at 12:21:55PM +0100, Ondrej Zary wrote:
> > Here, I am assuming that block/paride is the core code used by both
> > PARIDE and PATA_PARPORT. Not sure what PARPORT_PC does nor what its
> > dependency on block/paride code is.
> 
> There's no common core in block/paride. The block/paride/Makefile says:
> obj-$(CONFIG_PARIDE)            += paride.o
> obj-$(CONFIG_PARIDE_ATEN)       += aten.o
> obj-$(CONFIG_PARIDE_...other protocol drivers
> 
> So if PARIDE and all protocol drivers are disabled, nothing is compiled there.

Yeah.  The pattern of unconditionally descending into a subdirectory
isn't entirely uncommon.  I think this is perfectly fine here.