linux-kernel - Re: [PATCH v3] coresight: core: Fix coresight device probe failure issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 15 Mar 2022 16:52:58 +0800
From:   Jinlong Mao <quic_jinlmao@...cinc.com>
To:     Suzuki K Poulose <suzuki.poulose@....com>,
        Mathieu Poirier <mathieu.poirier@...aro.org>,
        Mike Leach <mike.leach@...aro.org>,
        Leo Yan <leo.yan@...aro.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>
CC:     <coresight@...ts.linaro.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
        "Tingwei Zhang" <quic_tingweiz@...cinc.com>,
        Yuanfang Zhang <quic_yuanfang@...cinc.com>,
        Tao Zhang <quic_taozha@...cinc.com>,
        Hao Zhang <quic_hazha@...cinc.com>
Subject: Re: [PATCH v3] coresight: core: Fix coresight device probe failure
 issue


On 3/15/2022 4:42 PM, Suzuki K Poulose wrote:
> On 15/03/2022 08:36, Jinlong Mao wrote:
>> On 3/10/2022 5:10 PM, Suzuki K Poulose wrote:
>>> Hi Jinlong
>>>
>>>
>>> On 09/03/2022 14:22, Mao Jinlong wrote:
>>>> It is possibe that probe failure issue happens when the device
>>>> and its child_device's probe happens at the same time.
>>>> In coresight_make_links, has_conns_grp is true for parent, but
>>>> has_conns_grp is false for child device as has_conns_grp is set
>>>> to true in coresight_create_conns_sysfs_group. The probe of parent
>>>> device will fail at this condition. Add has_conns_grp check for
>>>> child device before make the links and make the process from
>>>> device_register to connection_create be atomic to avoid this
>>>> probe failure issue.
>>>>
>>>> Suggested-by: Suzuki K Poulose <suzuki.poulose@....com>
>>>> Suggested-by: Mike Leach <mike.leach@...aro.org>
>>>> Signed-off-by: Mao Jinlong <quic_jinlmao@...cinc.com>
>>>
>>> Thanks for the rework. The patch looks good to me.
>>>
>>> Suzuki
>> Thanks Suzuki.
>>
>> Hi Mathieu & Mike,
>>
>> Could you please help to review and provide your comments for the 
>> PATCH V3 ?
>
> Thats what I just said above. The patch looks good to me, I can queue
> this in the next cycle.

Thanks Suzuki.

Best Regards
Jinlong Mao
>
> Kind regards
> Suzuki
>
>>
>> Thanks
>> Jinlong Mao
>