linux-kernel - Re: [GIT PULL] SPI fixes for v5.17-rc7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 15 Mar 2022 10:08:38 +0100
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Mark Brown <broonie@...nel.org>
Cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        linux-spi <linux-spi@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL] SPI fixes for v5.17-rc7

Hi Mark,

On Thu, Mar 10, 2022 at 3:46 PM Mark Brown <broonie@...nel.org> wrote:
> On Thu, Mar 10, 2022 at 04:25:34AM -0800, Linus Torvalds wrote:
> > On Thu, Mar 10, 2022 at 4:13 AM Mark Brown <broonie@...nel.org> wrote:
> > > One fix for type conversion issues when working out maximum
> > > scatter/gather segment sizes which caused problems for some systems
> > > which where the limits overflow due to the type conversion.
>
> > Side note: 'ctrl->max_dma_len' is a 'size_t', so even 'unsigned int'
> > isn't necessarily a sufficient type.
>
> Hrm, yes - thanks for spotting that.

I had noticed while reviewing the patch, but changing to size_t wouldn't
help much, as other related code paths treat the value as unsigned int
anyway.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds