linux-kernel - Re: [PATCH] powerpc/xive: Fix unsigned comparison with less than zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bfdaba1e-333e-669b-e5c0-8a3e891ade35@csgroup.eu>
Date:   Tue, 15 Mar 2022 10:17:40 +0100
From:   Christophe Leroy <christophe.leroy@...roup.eu>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>,
        mpe@...erman.id.au,
        Cédric Le Goater <clg@...d.org>
Cc:     paulus@...ba.org, linuxppc-dev@...ts.ozlabs.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] powerpc/xive: Fix unsigned comparison with less than zero



Le 07/05/2021 à 12:20, Jiapeng Chong a écrit :
> The return from the call to irq_domain_alloc_irqs() is int, it can be
> a negative error code, however this is being assigned to an unsigned
> int variable 'irq', this may lead to invalid if statement detection,
> so that kfree execution is invalid. So making 'irq' an int.
> 
> Clean up the following coccicheck warning:
> 
> ./arch/powerpc/sysdev/xive/common.c:1157:6-14: WARNING: Unsigned
> expression compared with zero: xid -> irq < 0.
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>

This was fixed by 
https://github.com/linuxppc/linux/commit/3f601608b71c3ca1e199898cd16f09d707fedb56

> ---
>   arch/powerpc/sysdev/xive/common.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/powerpc/sysdev/xive/common.c b/arch/powerpc/sysdev/xive/common.c
> index a830432..a5fd45a 100644
> --- a/arch/powerpc/sysdev/xive/common.c
> +++ b/arch/powerpc/sysdev/xive/common.c
> @@ -65,7 +65,7 @@
>   #ifdef CONFIG_SMP
>   /* The IPIs use the same logical irq number when on the same chip */
>   static struct xive_ipi_desc {
> -	unsigned int irq;
> +	int irq;
>   	char name[16];
>   } *xive_ipis;
>