linux-kernel - Re: [PATCH] powerpc:entry_32: correct the path and function name in the comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1ee4d3e1-5d56-cb60-fb98-d8861e674c74@csgroup.eu>
Date:   Tue, 15 Mar 2022 10:58:12 +0100
From:   Christophe Leroy <christophe.leroy@...roup.eu>
To:     chenzefeng <chenzefeng2@...wei.com>, mpe@...erman.id.au,
        benh@...nel.crashing.org, paulus@...ba.org,
        christophe.leroy@....fr, tglx@...utronix.de, bigeasy@...utronix.de,
        npiggin@...il.com
Cc:     linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
        zengweilin@...wei.com
Subject: Re: [PATCH] powerpc:entry_32: correct the path and function name in
 the comment



Le 07/08/2020 à 12:19, chenzefeng a écrit :
> Update the comment for file's directory and function name changed.

The function name changed again with commit 714acdbd1c94 ("arch: rename 
copy_thread_tls() back to copy_thread()")

Please update the patch to just drop the file name. Users are able to 
find where the function is by themselves.

Thanks
Christophe

> 
> Fixes: facd04a904ff ("powerpc: convert to copy_thread_tls")
> Fixes: 14cf11af6cf6 ("powerpc: Merge enough to start building in arch/powerpc.")
> 
> Signed-off-by: chenzefeng <chenzefeng2@...wei.com>
> ---
>   arch/powerpc/kernel/entry_32.S | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/powerpc/kernel/entry_32.S b/arch/powerpc/kernel/entry_32.S
> index 8420abd4ea1c..9937593d3a33 100644
> --- a/arch/powerpc/kernel/entry_32.S
> +++ b/arch/powerpc/kernel/entry_32.S
> @@ -696,8 +696,8 @@ handle_dabr_fault:
>    * to the "_switch" path.  If you change this , you'll have to
>    * change the fork code also.
>    *
> - * The code which creates the new task context is in 'copy_thread'
> - * in arch/ppc/kernel/process.c
> + * The code which creates the new task context is in 'copy_thread_tls'
> + * in arch/powerpc/kernel/process.c
>    */
>   _GLOBAL(_switch)
>   	stwu	r1,-INT_FRAME_SIZE(r1)