linux-kernel - Re: [PATCH linux-next] macintosh: fix warning comparing pointer to 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c30b26fa-0495-89aa-c504-6fee09f86c56@csgroup.eu>
Date:   Tue, 15 Mar 2022 11:09:46 +0100
From:   Christophe Leroy <christophe.leroy@...roup.eu>
To:     jing yangyang <cgel.zte@...il.com>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>
Cc:     Zeal Robot <zealci@....com.cn>, linuxppc-dev@...ts.ozlabs.org,
        linux-kernel@...r.kernel.org,
        jing yangyang <jing.yangyang@....com.cn>
Subject: Re: [PATCH linux-next] macintosh: fix warning comparing pointer to 0



Le 20/08/2021 à 04:34, jing yangyang a écrit :
> Fix the following coccicheck warning:
> 
> ./drivers/macintosh/windfarm_pm91.c:152:12-13:WARNING comparing pointer to 0
> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: jing yangyang <jing.yangyang@....com.cn>

WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address 
mismatch: 'From: jing yangyang <cgel.zte@...il.com>' != 'Signed-off-by: 
jing yangyang <jing.yangyang@....com.cn>'

Please resend.

Thanks
Christophe


> ---
>   drivers/macintosh/windfarm_pm91.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/macintosh/windfarm_pm91.c b/drivers/macintosh/windfarm_pm91.c
> index 3f346af..568f8a2 100644
> --- a/drivers/macintosh/windfarm_pm91.c
> +++ b/drivers/macintosh/windfarm_pm91.c
> @@ -149,7 +149,7 @@ static void wf_smu_create_cpu_fans(void)
>   
>   	/* First, locate the PID params in SMU SBD */
>   	hdr = smu_get_sdb_partition(SMU_SDB_CPUPIDDATA_ID, NULL);
> -	if (hdr == 0) {
> +	if (!hdr) {
>   		printk(KERN_WARNING "windfarm: CPU PID fan config not found "
>   		       "max fan speed\n");
>   		goto fail;