linux-kernel - Re: [PATCH] pinctrl: zynq: use module_platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdbtMstgexY2C+Egoqt+jFV7JaV4Qe6ZiogpBNswtSEX4w@mail.gmail.com>
Date:   Tue, 15 Mar 2022 01:47:26 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Srinivas Neeli <srinivas.neeli@...inx.com>
Cc:     michal.simek@...inx.com, linux-gpio@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        shubhrajyoti.datta@...inx.com, git@...inx.com, sgoud@...inx.com
Subject: Re: [PATCH] pinctrl: zynq: use module_platform_driver to simplify the code

On Thu, Feb 24, 2022 at 5:36 AM Srinivas Neeli
<srinivas.neeli@...inx.com> wrote:

> module_platform_driver() makes the code simpler by eliminating
> boilerplate code.
>
> Signed-off-by: Srinivas Neeli <srinivas.neeli@...inx.com>

Nice, patch applied!

> -static int __init zynq_pinctrl_init(void)
> -{
> -       return platform_driver_register(&zynq_pinctrl_driver);
> -}
> -arch_initcall(zynq_pinctrl_init);
> +module_platform_driver(zynq_pinctrl_driver);

This will incidentally also move the initcall from arch_initcall
to driver_initcall but I assume that works so, OK.

Yours,
Linus Walleij