linux-kernel - Re: [PATCH] mmc: core: Improve fallback to speed modes if eMMC HS200 fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPDyKFosSVMOXtin149h=YaLeMEUq3Q0-xwYcg0ZgcfWRbawvA@mail.gmail.com>
Date:   Tue, 15 Mar 2022 13:22:42 +0100
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Heiner Kallweit <hkallweit1@...il.com>
Cc:     linux-mmc@...r.kernel.org, Adrian Hunter <adrian.hunter@...el.com>,
        Wolfram Sang <wsa+renesas@...g-engineering.com>,
        Yann Gautier <yann.gautier@...s.st.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mmc: core: Improve fallback to speed modes if eMMC HS200 fails

On Mon, 14 Mar 2022 at 23:02, Heiner Kallweit <hkallweit1@...il.com> wrote:
>
> On 14.03.2022 11:54, Ulf Hansson wrote:
> > On Thu, 3 Mar 2022 at 17:45, Ulf Hansson <ulf.hansson@...aro.org> wrote:
> >>
> >> In the error path of mmc_select_hs200() we are trying our best to restore
> >> the card/host into a valid state. This makes sense, especially if we
> >> encounter a simple switch error (-EBADMSG). However, rather than then
> >> continue with using the legacy speed mode, let's try the other better speed
> >> modes first. Additionally, let's update the card->mmc_avail_type to avoid
> >> us from trying a broken HS200 mode again.
> >>
> >> In an Amlogic S905W based TV box where the switch to HS200 mode fails for
> >> the eMMC, this allows us to use the eMMC in DDR mode in favor of the legacy
> >> mode, which greatly improves the performance.
> >>
> >> Suggested-by: Heiner Kallweit <hkallweit1@...il.com>
> >> Signed-off-by: Ulf Hansson <ulf.hansson@...aro.org>
> >
> > Heiner, does this solve your problems? Can you perhaps run some tests
> > at your side to see how it works for you?
> >
>
> Tested-by: Heiner Kallweit <hkallweit1@...il.com>

Thanks! Patch applied for next.

[...]

Kind regards
Uffe