linux-kernel - Re: [PATCH v2] mmc: mtk-sd: Silence delay phase calculation debug log

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPDyKFp4QbaCvOQoK_5rdh4X_iuvvsZ6M-iGiBCNp-VuQ+WChg@mail.gmail.com>
Date:   Tue, 15 Mar 2022 13:22:59 +0100
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Alexandre Bailon <abailon@...libre.com>
Cc:     chaotian.jing@...iatek.com, matthias.bgg@...il.com,
        linux-mmc@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>
Subject: Re: [PATCH v2] mmc: mtk-sd: Silence delay phase calculation debug log

On Fri, 11 Mar 2022 at 11:33, Alexandre Bailon <abailon@...libre.com> wrote:
>
> The driver prints the following log everytime data is written to RPMB:
> mtk-msdc 11230000.mmc: phase: [map:ffffffff] [maxlen:32] [final:10]
>
> dev_info is used to print that log but it seems that log is only
> useful for debbuging. Use dev_dbg instead of dev_info.
>
> Signed-off-by: Alexandre Bailon <abailon@...libre.com>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/mtk-sd.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> index d5a9c269d492..05c8b4de46f3 100644
> --- a/drivers/mmc/host/mtk-sd.c
> +++ b/drivers/mmc/host/mtk-sd.c
> @@ -1914,8 +1914,8 @@ static struct msdc_delay_phase get_best_delay(struct msdc_host *host, u32 delay)
>                 final_phase = (start_final + len_final / 3) % PAD_DELAY_MAX;
>         else
>                 final_phase = (start_final + len_final / 2) % PAD_DELAY_MAX;
> -       dev_info(host->dev, "phase: [map:%x] [maxlen:%d] [final:%d]\n",
> -                delay, len_final, final_phase);
> +       dev_dbg(host->dev, "phase: [map:%x] [maxlen:%d] [final:%d]\n",
> +               delay, len_final, final_phase);
>
>         delay_phase.maxlen = len_final;
>         delay_phase.start = start_final;
> --
> 2.34.1
>