[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAFr9PXn=vRV4Jvxc+w9XJiAB8eAzq9MUfu+frMkS1P83Vp2Ujw@mail.gmail.com>
Date: Tue, 15 Mar 2022 22:26:41 +0900
From: Daniel Palmer <daniel@...f.com>
To: Arnaud POULIQUEN <arnaud.pouliquen@...com>
Cc: Takashi Iwai <tiwai@...e.de>,
"broonie@...nel.org" <broonie@...nel.org>,
"tiwai@...e.com" <tiwai@...e.com>,
"alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ASoC: sti: sti_uniperif: Remove driver
Hi Arnaud,
On Tue, 15 Mar 2022 at 22:15, Arnaud POULIQUEN <arnaud.pouliquen@...com> wrote:
> > Yeah, that looks dead.
> >
>
> The platform is still used for instance:
> https://lore.kernel.org/all/1d95209f-9cb4-47a3-2696-7a93df7cdc05@foss.st.com/
>
> So please do not remove the driver
>
> The issue has not been detected because it is related to an error that
> occurs only when we reach the limit of the platform, with application
> that stop the stream at same time.
> So almost no chance to occur.
>
> > OTOH, if anyone really wants to keep the stuff, please revert the
> > commit dc865fb9e7c2251c9585ff6a7bf185d499db13e4.
>
> Yes reverting the commit is one solution.
> The other is to clean-up the snd_pcm_stream_lock/ snd_pcm_stream_unlock in the
> Handler.
>
> I will try to address this in few weeks
Feel free to ignore my patch then. I couldn't find anything that used
it's DT compatible etc and assumed it was orphaned.
Cheers,
Daniel
Powered by blists - more mailing lists