linux-kernel - Re: [PATCH] staging: rts5208: Resolve checkpath.pl issues.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 15 Mar 2022 15:20:07 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Charlie Sands <sandsch@...thvilleschools.net>
Cc:     linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rts5208: Resolve checkpath.pl issues.

On Mon, Mar 14, 2022 at 10:27:40PM -0400, Charlie Sands wrote:
> This patch remedies the following checkpath.pl issues:
> 
> WARNING: Unnecessary ftrace-like logging - prefer using ftrace
> + dev_info(&dev->pci->dev, "%s called\n", __func__);
> 
> WARNING: Unnecessary ftrace-like logging - prefer using ftrace
> + dev_info(&dev->pci->dev, "%s called\n", __func__);
> 
> WARNING: Unnecessary ftrace-like logging - prefer using ftrace
> + dev_info(&pci->dev, "%s called\n", __func__);
> 
> Signed-off-by: Charlie Sands <sandsch@...thvilleschools.net>
> ---
>  drivers/staging/rts5208/rtsx.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c
> index 5a58dac76c88..643d33b9a239 100644
> --- a/drivers/staging/rts5208/rtsx.c
> +++ b/drivers/staging/rts5208/rtsx.c
> @@ -159,8 +159,6 @@ static int command_abort(struct scsi_cmnd *srb)
>  	struct rtsx_dev *dev = host_to_rtsx(host);
>  	struct rtsx_chip *chip = dev->chip;
>  
> -	dev_info(&dev->pci->dev, "%s called\n", __func__);
> -
>  	scsi_lock(host);
>  
>  	/* Is this command still active? */
> @@ -188,8 +186,6 @@ static int device_reset(struct scsi_cmnd *srb)
>  {
>  	struct rtsx_dev *dev = host_to_rtsx(srb->device->host);
>  
> -	dev_info(&dev->pci->dev, "%s called\n", __func__);
> -
>  	return SUCCESS;
>  }
>  
> @@ -968,8 +964,6 @@ static void rtsx_remove(struct pci_dev *pci)
>  {
>  	struct rtsx_dev *dev = pci_get_drvdata(pci);
>  
> -	dev_info(&pci->dev, "%s called\n", __func__);
> -
>  	quiesce_and_remove_host(dev);
>  	release_everything(dev);
>  	pci_release_regions(pci);
> -- 
> 2.35.1
> 
> 

Always test-build your patches.  Applying this change results in a build
failure :(

Please fix up and resend.

thanks,

greg k-h