linux-kernel - RE: [PATCH] iwlwifi: mei: fix building iwlmei

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SA1PR11MB5825D9DDC4F622A9B8FA77B9F2119@SA1PR11MB5825.namprd11.prod.outlook.com>
Date:   Wed, 16 Mar 2022 18:55:41 +0000
From:   "Grumbach, Emmanuel" <emmanuel.grumbach@...el.com>
To:     Arnd Bergmann <arnd@...nel.org>,
        "Coelho, Luciano" <luciano.coelho@...el.com>,
        Kalle Valo <kvalo@...nel.org>
CC:     Arnd Bergmann <arnd@...db.de>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        "Beker, Ayala" <ayala.beker@...el.com>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] iwlwifi: mei: fix building iwlmei

> 
> From: Arnd Bergmann <arnd@...db.de>
> 
> Building iwlmei without CONFIG_CFG80211 causes a link-time warning:
> 
> ld.lld: error: undefined symbol: ieee80211_hdrlen
> >>> referenced by net.c
> >>>
> >>> net/wireless/intel/iwlwifi/mei/net.o:(iwl_mei_tx_copy_to_csme) in
> >>> archive drivers/built-in.a
> 
> Add an explicit dependency to avoid this. In theory it should not be needed
> here, but it also seems pointless to allow IWLMEI for configurations without
> CFG80211.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/net/wireless/intel/iwlwifi/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> I see this warning on 5.17-rc8, but did not test it on linux-next, which may
> already have a fix.
> 
> diff --git a/drivers/net/wireless/intel/iwlwifi/Kconfig
> b/drivers/net/wireless/intel/iwlwifi/Kconfig
> index 85e704283755..a647a406b87b 100644
> --- a/drivers/net/wireless/intel/iwlwifi/Kconfig
> +++ b/drivers/net/wireless/intel/iwlwifi/Kconfig
> @@ -139,6 +139,7 @@ config IWLMEI
>  	tristate "Intel Management Engine communication over WLAN"
>  	depends on INTEL_MEI
>  	depends on PM
> +	depends on CFG80211
>  	help
>  	  Enables the iwlmei kernel module.
> 

FWIW: Luca just merged the exact same patch internally. So
Acked-by: Emmanuel Grumbach <Emmanuel.grumbach@...el.com>