linux-kernel - [mingo-tip:master 387/2335] net/sched/sch_generic.c:410:6: warning: no previous prototype for '__qdisc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202203170235.orakWDQu-lkp@intel.com>
Date:   Thu, 17 Mar 2022 03:06:38 +0800
From:   kernel test robot <lkp@...el.com>
To:     Ingo Molnar <mingo@...nel.org>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: [mingo-tip:master 387/2335] net/sched/sch_generic.c:410:6: warning:
 no previous prototype for '__qdisc_run'

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/mingo/tip.git master
head:   85293bf3fca6d85608cff1447ce3097583f15fab
commit: 1f7534c4ddd683aee3bb596dcaa839359aa7813d [387/2335] headers/uninline: Uninline single-use function: qdisc_run()
config: i386-randconfig-a001-20220314 (https://download.01.org/0day-ci/archive/20220317/202203170235.orakWDQu-lkp@intel.com/config)
compiler: gcc-9 (Ubuntu 9.4.0-1ubuntu1~20.04) 9.4.0
reproduce (this is a W=1 build):
        # https://git.kernel.org/pub/scm/linux/kernel/git/mingo/tip.git/commit/?id=1f7534c4ddd683aee3bb596dcaa839359aa7813d
        git remote add mingo-tip git://git.kernel.org/pub/scm/linux/kernel/git/mingo/tip.git
        git fetch --no-tags mingo-tip master
        git checkout 1f7534c4ddd683aee3bb596dcaa839359aa7813d
        # save the config file to linux build tree
        mkdir build_dir
        make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash arch/x86/entry/vdso/ arch/x86/pci/ kernel/ lib/ net/sched/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> net/sched/sch_generic.c:410:6: warning: no previous prototype for '__qdisc_run' [-Wmissing-prototypes]
     410 | void __qdisc_run(struct Qdisc *q)
         |      ^~~~~~~~~~~


vim +/__qdisc_run +410 net/sched/sch_generic.c

bbd8a0d3a3b65d Krishna Kumar          2009-08-06  409  
37437bb2e1ae8a David S. Miller        2008-07-16 @410  void __qdisc_run(struct Qdisc *q)
48d83325b61043 Herbert Xu             2006-06-19  411  {
3d48b53fb2ae37 Matthias Tafelmeier    2016-12-29  412  	int quota = dev_tx_weight;
b8358d70ce1066 Jesper Dangaard Brouer 2014-10-09  413  	int packets;
2ba2506ca7ca62 Herbert Xu             2008-03-28  414  
b8358d70ce1066 Jesper Dangaard Brouer 2014-10-09  415  	while (qdisc_restart(q, &packets)) {
b8358d70ce1066 Jesper Dangaard Brouer 2014-10-09  416  		quota -= packets;
b60fa1c5d01a10 Eric Dumazet           2019-10-01  417  		if (quota <= 0) {
c4fef01ba4793a Yunsheng Lin           2021-06-22  418  			if (q->flags & TCQ_F_NOLOCK)
c4fef01ba4793a Yunsheng Lin           2021-06-22  419  				set_bit(__QDISC_STATE_MISSED, &q->state);
c4fef01ba4793a Yunsheng Lin           2021-06-22  420  			else
37437bb2e1ae8a David S. Miller        2008-07-16  421  				__netif_schedule(q);
c4fef01ba4793a Yunsheng Lin           2021-06-22  422  
d90df3ad07a20c Herbert Xu             2007-05-10  423  			break;
2ba2506ca7ca62 Herbert Xu             2008-03-28  424  		}
2ba2506ca7ca62 Herbert Xu             2008-03-28  425  	}
48d83325b61043 Herbert Xu             2006-06-19  426  }
48d83325b61043 Herbert Xu             2006-06-19  427  

:::::: The code at line 410 was first introduced by commit
:::::: 37437bb2e1ae8af470dfcd5b4ff454110894ccaf pkt_sched: Schedule qdiscs instead of netdev_queue.

:::::: TO: David S. Miller <davem@...emloft.net>
:::::: CC: David S. Miller <davem@...emloft.net>

---
0-DAY CI Kernel Test Service
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org