linux-kernel - Re: [PATCH V2,2/2] mm: madvise: skip unmapped vma holes passed to process

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220316142906.e41e39d2315e35ef43f4aad6@linux-foundation.org>
Date:   Wed, 16 Mar 2022 14:29:06 -0700
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Charan Teja Kalla <quic_charante@...cinc.com>
Cc:     Minchan Kim <minchan@...nel.org>, <surenb@...gle.com>,
        <vbabka@...e.cz>, <rientjes@...gle.com>, <sfr@...b.auug.org.au>,
        <edgararriaga@...gle.com>, <nadav.amit@...il.com>,
        <mhocko@...e.com>, <linux-mm@...ck.org>,
        <linux-kernel@...r.kernel.org>,
        "# 5 . 10+" <stable@...r.kernel.org>
Subject: Re: [PATCH V2,2/2] mm: madvise: skip unmapped vma holes passed to
 process_madvise

On Wed, 16 Mar 2022 19:49:38 +0530 Charan Teja Kalla <quic_charante@...cinc.com> wrote:

> > IMO, it's worth to note in man page.
> > 
> 
> Or the current patch for just ENOMEM is sufficient here and we just have
> to update the man page?

I think the "On success, process_madvise() returns the number of bytes
advised" behaviour sounds useful.  But madvise() doesn't do that.

RETURN VALUE
       On  success, madvise() returns zero.  On error, it returns -1 and errno
       is set to indicate the error.

So why is it desirable in the case of process_madvise()?



And why was process_madvise() designed this way?   Or was it
always simply an error in the manpage?