linux-kernel - [ammarfaizi2-block:google/android/kernel/common/android-4.19-q-release 499/7636] fs/f2fs/data.c:420:47: sparse: sparse: Using plain integer as NULL pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Message-ID: <202203161001.WNuuYWHv-lkp@intel.com>
Date:   Wed, 16 Mar 2022 10:54:16 +0800
From:   kernel test robot <lkp@...el.com>
To:     Chao Yu <yuchao0@...wei.com>, Chao Yu <chao@...nel.org>
Cc:     kbuild-all@...ts.01.org,
        GNU/Weeb Mailing List <gwml@...r.gnuweeb.org>,
        linux-kernel@...r.kernel.org, Jaegeuk Kim <jaegeuk@...nel.org>
Subject: [ammarfaizi2-block:google/android/kernel/common/android-4.19-q-release
 499/7636] fs/f2fs/data.c:420:47: sparse: sparse: Using plain integer as NULL
 pointer

tree:   https://github.com/ammarfaizi2/linux-block google/android/kernel/common/android-4.19-q-release
head:   1a3500dc59324a85c20f025cfa6485a1a0debbdf
commit: c258edb28a2a2f7db55d849efa431fca304a4851 [499/7636] Revert: "f2fs: check last page index in cached bio to decide submission"
config: x86_64-randconfig-s021 (https://download.01.org/0day-ci/archive/20220316/202203161001.WNuuYWHv-lkp@intel.com/config)
compiler: gcc-9 (Ubuntu 9.4.0-1ubuntu1~20.04) 9.4.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.4-dirty
        # https://github.com/ammarfaizi2/linux-block/commit/c258edb28a2a2f7db55d849efa431fca304a4851
        git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block
        git fetch --no-tags ammarfaizi2-block google/android/kernel/common/android-4.19-q-release
        git checkout c258edb28a2a2f7db55d849efa431fca304a4851
        # save the config file to linux build tree
        mkdir build_dir
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=x86_64 SHELL=/bin/bash fs/f2fs/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>


sparse warnings: (new ones prefixed by >>)
>> fs/f2fs/data.c:420:47: sparse: sparse: Using plain integer as NULL pointer
   In file included from fs/f2fs/data.c:22:
   fs/f2fs/f2fs.h: In function 'blkaddr_in_node':
   fs/f2fs/f2fs.h:2147:30: warning: taking address of packed member of 'struct f2fs_inode' may result in an unaligned pointer value [-Waddress-of-packed-member]
    2147 |  return RAW_IS_INODE(node) ? node->i.i_addr : node->dn.addr;
         |                              ^~~~
   fs/f2fs/f2fs.h:2147:47: warning: taking address of packed member of 'struct direct_node' may result in an unaligned pointer value [-Waddress-of-packed-member]
    2147 |  return RAW_IS_INODE(node) ? node->i.i_addr : node->dn.addr;
         |                                               ^~~~
   fs/f2fs/f2fs.h: In function '__mark_inode_dirty_flag':
   fs/f2fs/f2fs.h:2340:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
    2340 |   if (set)
         |      ^
   fs/f2fs/f2fs.h:2342:2: note: here
    2342 |  case FI_DATA_EXIST:
         |  ^~~~
   fs/f2fs/data.o: warning: objtool: f2fs_xattr_fiemap()+0x312: sibling call from callable instruction with modified stack frame
   fs/f2fs/data.o: warning: objtool: f2fs_set_data_page_dirty()+0x380: sibling call from callable instruction with modified stack frame
   fs/f2fs/data.o: warning: objtool: f2fs_direct_IO()+0xd4: sibling call from callable instruction with modified stack frame
   fs/f2fs/data.o: warning: objtool: f2fs_write_end()+0x3cc: sibling call from callable instruction with modified stack frame
   fs/f2fs/data.o: warning: objtool: __submit_merged_bio()+0x91e: sibling call from callable instruction with modified stack frame
   fs/f2fs/data.o: warning: objtool: f2fs_submit_page_read()+0x312: sibling call from callable instruction with modified stack frame
   fs/f2fs/data.o: warning: objtool: f2fs_submit_page_bio()+0x719: sibling call from callable instruction with modified stack frame
   fs/f2fs/data.o: warning: objtool: f2fs_submit_page_write()+0xb7: sibling call from callable instruction with modified stack frame
   fs/f2fs/data.o: warning: objtool: __allocate_data_block()+0x599: sibling call from callable instruction with modified stack frame
   fs/f2fs/data.o: warning: objtool: f2fs_reserve_new_blocks()+0x8f: sibling call from callable instruction with modified stack frame
   fs/f2fs/data.o: warning: objtool: prepare_write_begin()+0x6f3: sibling call from callable instruction with modified stack frame
   fs/f2fs/data.o: warning: objtool: f2fs_write_begin()+0x1da: sibling call from callable instruction with modified stack frame
   fs/f2fs/data.o: warning: objtool: f2fs_map_blocks()+0xe8a: sibling call from callable instruction with modified stack frame
   fs/f2fs/data.o: warning: objtool: f2fs_mpage_readpages()+0x51: sibling call from callable instruction with modified stack frame
   fs/f2fs/data.o: warning: objtool: f2fs_read_data_pages()+0x1d4: sibling call from callable instruction with modified stack frame
   fs/f2fs/data.o: warning: objtool: f2fs_read_data_page()+0x1de: sibling call from callable instruction with modified stack frame
   fs/f2fs/data.o: warning: objtool: __get_data_block()+0x41: sibling call from callable instruction with modified stack frame
   fs/f2fs/data.o: warning: objtool: f2fs_fiemap()+0xf7: sibling call from callable instruction with modified stack frame
   fs/f2fs/data.o: warning: objtool: f2fs_should_update_inplace()+0x1fc: sibling call from callable instruction with modified stack frame
   fs/f2fs/data.o: warning: objtool: f2fs_do_write_data_page()+0x1097: sibling call from callable instruction with modified stack frame
   fs/f2fs/data.o: warning: objtool: __write_data_page()+0x469: sibling call from callable instruction with modified stack frame
   fs/f2fs/data.o: warning: objtool: f2fs_write_cache_pages()+0x587: sibling call from callable instruction with modified stack frame
   fs/f2fs/data.o: warning: objtool: __f2fs_write_data_pages()+0x6cb: sibling call from callable instruction with modified stack frame
   fs/f2fs/data.o: warning: objtool: f2fs_xattr_fiemap.cold()+0x14: call without frame pointer save/setup
   fs/f2fs/data.o: warning: objtool: f2fs_set_data_page_dirty.cold()+0x12: call without frame pointer save/setup
   fs/f2fs/data.o: warning: objtool: f2fs_direct_IO.cold()+0xf: call without frame pointer save/setup
   fs/f2fs/data.o: warning: objtool: f2fs_write_end.cold()+0x15: call without frame pointer save/setup
   fs/f2fs/data.o: warning: objtool: __submit_merged_bio.cold()+0x12: call without frame pointer save/setup
   fs/f2fs/data.o: warning: objtool: f2fs_submit_page_read.cold()+0x15: call without frame pointer save/setup
   fs/f2fs/data.o: warning: objtool: f2fs_submit_page_bio.cold()+0x13: call without frame pointer save/setup
   fs/f2fs/data.o: warning: objtool: f2fs_submit_page_write.cold()+0x15: call without frame pointer save/setup
   fs/f2fs/data.o: warning: objtool: __allocate_data_block.cold()+0x12: call without frame pointer save/setup
   fs/f2fs/data.o: warning: objtool: f2fs_reserve_new_blocks.cold()+0x1a: call without frame pointer save/setup
   fs/f2fs/data.o: warning: objtool: prepare_write_begin.cold()+0xa: call without frame pointer save/setup
   fs/f2fs/data.o: warning: objtool: f2fs_write_begin.cold()+0x17: call without frame pointer save/setup
   fs/f2fs/data.o: warning: objtool: f2fs_map_blocks.cold()+0x16: call without frame pointer save/setup
   fs/f2fs/data.o: warning: objtool: f2fs_mpage_readpages.cold()+0x15: call without frame pointer save/setup
   fs/f2fs/data.o: warning: objtool: f2fs_read_data_pages.cold()+0x12: call without frame pointer save/setup
   fs/f2fs/data.o: warning: objtool: f2fs_read_data_page.cold()+0x12: call without frame pointer save/setup
   fs/f2fs/data.o: warning: objtool: __get_data_block.cold()+0x18: call without frame pointer save/setup
   fs/f2fs/data.o: warning: objtool: f2fs_fiemap.cold()+0x10: call without frame pointer save/setup
   fs/f2fs/data.o: warning: objtool: f2fs_should_update_inplace.cold()+0x14: call without frame pointer save/setup
   fs/f2fs/data.o: warning: objtool: f2fs_do_write_data_page.cold()+0x13: call without frame pointer save/setup
   fs/f2fs/data.o: warning: objtool: __write_data_page.cold()+0x18: call without frame pointer save/setup
   fs/f2fs/data.o: warning: objtool: f2fs_write_cache_pages.cold()+0x13: call without frame pointer save/setup
   fs/f2fs/data.o: warning: objtool: __f2fs_write_data_pages.cold()+0x13: call without frame pointer save/setup

vim +420 fs/f2fs/data.c

a912b54d3aaa01 Jaegeuk Kim 2017-05-10  417  
b9109b0e49b93b Jaegeuk Kim 2017-05-10  418  void f2fs_submit_merged_write(struct f2fs_sb_info *sbi, enum page_type type)
0c3a579758362d Chao Yu     2016-01-18  419  {
a912b54d3aaa01 Jaegeuk Kim 2017-05-10 @420  	__submit_merged_write_cond(sbi, NULL, 0, 0, type, true);
0c3a579758362d Chao Yu     2016-01-18  421  }
0c3a579758362d Chao Yu     2016-01-18  422  

:::::: The code at line 420 was first introduced by commit
:::::: a912b54d3aaa011266dc266e3694f782f27233cf f2fs: split bio cache

:::::: TO: Jaegeuk Kim <jaegeuk@...nel.org>
:::::: CC: Jaegeuk Kim <jaegeuk@...nel.org>

---
0-DAY CI Kernel Test Service
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org