linux-kernel - RE: [PATCH v3] kallsyms: enhance %pS/s/b printing when KALLSYSMS is disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <453510261.3922147.1647405593710@mail-kr5-2>
Date:   Wed, 16 Mar 2022 10:09:53 +0530
From:   Maninder Singh <maninder1.s@...sung.com>
To:     Luis Chamberlain <mcgrof@...nel.org>
CC:     "pmladek@...e.com" <pmladek@...e.com>,
        "rostedt@...dmis.org" <rostedt@...dmis.org>,
        "senozhatsky@...omium.org" <senozhatsky@...omium.org>,
        "andriy.shevchenko@...ux.intel.com" 
        <andriy.shevchenko@...ux.intel.com>,
        "linux@...musvillemoes.dk" <linux@...musvillemoes.dk>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "wangkefeng.wang@...wei.com" <wangkefeng.wang@...wei.com>,
        Vaneet Narang <v.narang@...sung.com>,
        "swboyd@...omium.org" <swboyd@...omium.org>,
        "ojeda@...nel.org" <ojeda@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-modules@...r.kernel.org" <linux-modules@...r.kernel.org>,
        "avimalin@...il.com" <avimalin@...il.com>,
        "atomlin@...hat.com" <atomlin@...hat.com>
Subject: RE: [PATCH v3] kallsyms: enhance %pS/s/b printing when KALLSYSMS is
 disabled

Hi Luis,

>> ---
>> commit id 'kallsyms: print module name in %ps/S case when KALLSYMS is disabled'
>>         needs to be removed from mm(linux-next) tree, current change is
>>         with ignorance of this commit. I was not sure how to send patch, with 2 patches
>>         consisting reversal commit also, or current approach is correct.
>> 
>> v1->v2: hash base address of module, change *fmt to fmt[0] and removed
>>         copy paste.
>> v2->v3: fixed review comments from Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
>> 
>>  include/linux/kallsyms.h |  2 +
>>  include/linux/module.h   | 20 ++++++++++
>>  kernel/kallsyms.c        | 27 +++++++------
>>  kernel/module.c          |  4 +-
>>  lib/vsprintf.c           | 85 ++++++++++++++++++++++++++++++++++------
> 
> Hey Maninder, thanks for your patch!
>  
> Since this touches kernel/module.c and include/linux/module.h I'd prefer
> this go through modules-next [0], and as you will see that's a different
> world right now. I also have a set of at least 2 other patch sets to
> merge there before yours.
>  
> Also, what is on modules-next is not intended to go to Linus for the
> next merge window as the changes there got merged only late, and I want
> at least 2 months of testing on linux-newt before any pull requiest is
> sent to Linus.
>  
> Can you rebase to modules-next? I can evaluate the patches then for
> integration there once the other stuff gets merged into that tree too.
>  
> [0] https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git/log/?h=modules-next
>  
>   Luis

prepared and verified patch(KALLSYMS enabled and disabled both) on module-next rebase and sent in new mail.
[PATCH 1/1 module-next] kallsyms: enhance %pS/s/b printing when KALLSYSMS is disabled

https://lkml.org/lkml/2022/3/16/7

Thanks,
Maninder Singh
Download attachment "rcptInfo.txt" of type "application/octet-stream" (1664 bytes)