linux-kernel - Re: [RESEND PATCH 6/6] counter: add defaults to switch-statements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 16 Mar 2022 13:07:57 +0530
From:   Syed Nayyar Waris <syednwaris@...il.com>
To:     William Breathitt Gray <vilhelm.gray@...il.com>
Cc:     gregkh@...uxfoundation.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-iio@...r.kernel.org, Tom Rix <trix@...hat.com>,
        Jonathan Cameron <Jonathan.Cameron@...wei.com>
Subject: Re: [RESEND PATCH 6/6] counter: add defaults to switch-statements

On Wed, Mar 16, 2022 at 12:43 PM William Breathitt Gray
<vilhelm.gray@...il.com> wrote:
>
> From: Tom Rix <trix@...hat.com>
>
> Clang static analysis reports this representative problem
> counter-chrdev.c:482:3: warning: Undefined or garbage value
>   returned to caller
>   return ret;
>   ^~~~~~~~~~
>
> counter_get_data() has a multilevel switches, some without
> defaults, so ret is sometimes not set.
> Add returning -EINVAL similar to other defaults.
>
> Signed-off-by: Tom Rix <trix@...hat.com>
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>
> Link: https://lore.kernel.org/r/20220227161746.82776-1-trix@redhat.com
> Signed-off-by: William Breathitt Gray <vilhelm.gray@...il.com>
> ---
>  drivers/counter/counter-chrdev.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/counter/counter-chrdev.c b/drivers/counter/counter-chrdev.c
> index b7c62f957a6a..69d340be9c93 100644
> --- a/drivers/counter/counter-chrdev.c
> +++ b/drivers/counter/counter-chrdev.c
> @@ -477,6 +477,8 @@ static int counter_get_data(struct counter_device *const counter,
>                 case COUNTER_SCOPE_COUNT:
>                         ret = comp->count_u8_read(counter, parent, &value_u8);
>                         break;
> +               default:
> +                       return -EINVAL;
>                 }
>                 *value = value_u8;
>                 return ret;
> @@ -496,6 +498,8 @@ static int counter_get_data(struct counter_device *const counter,
>                 case COUNTER_SCOPE_COUNT:
>                         ret = comp->count_u32_read(counter, parent, &value_u32);
>                         break;
> +               default:
> +                       return -EINVAL;
>                 }
>                 *value = value_u32;
>                 return ret;
> --
> 2.35.1
>

Acked-by: Syed Nayyar Waris <syednwaris@...il.com>

Thanks