linux-kernel - Re: [PATCH v2 1/3] mm/memory-failure.c: fix race with changing page compound again

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220316083046.GB3840907@hori.linux.bs1.fc.nec.co.jp>
Date:   Wed, 16 Mar 2022 08:30:46 +0000
From:   HORIGUCHI NAOYA(堀口　直也) 
        <naoya.horiguchi@....com>
To:     Miaohe Lin <linmiaohe@...wei.com>
CC:     Yang Shi <shy828301@...il.com>,
        Mike Kravetz <mike.kravetz@...cle.com>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "tony.luck@...el.com" <tony.luck@...el.com>,
        "bp@...en8.de" <bp@...en8.de>
Subject: Re: [PATCH v2 1/3] mm/memory-failure.c: fix race with changing page
 compound again

On Wed, Mar 16, 2022 at 04:18:30PM +0800, Miaohe Lin wrote:
> On 2022/3/16 2:19, Yang Shi wrote:
> > On Tue, Mar 15, 2022 at 7:19 AM Miaohe Lin <linmiaohe@...wei.com> wrote:
...
> >>
> >>
> >> Many thanks for comment.
> >> I assume that Naoya's patch "mm/hwpoison: set PageHWPoison after taking page lock
> >> in memory_failure_hugetlb()" would set the PageHWPoison after the above check.
> >> So I think the below operation is not needed as PageHWPoison is not set yet.
> >> Does this makes sense for you?
> > 
> > I'm wondering if it might be better and helpful for review to squash
> > this patch with Naoya's patch together? It seems we always missed the
> > other part when reviewing the patches.
> > 
> 
> Sounds like a good idea. This would make the reviewer's life easier. I'm fine if
> this patch is squashed into Naoya's patch altogether. But we might have to consult
> the opinion from Naoya.

I'm fine with the squashing, so I'll send v4.

Thanks,
Naoya Horiguchi