linux-kernel - Re: [PATCH v2] hugetlb: Fix comments about avoiding atomic allocation of vmemmap pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMZfGtVi7zOM7pdj1rv1OY2VyOpKQU45YFjM4KqMEQn=KGHq3w@mail.gmail.com>
Date:   Wed, 16 Mar 2022 16:48:51 +0800
From:   Muchun Song <songmuchun@...edance.com>
To:     luofei <luofei@...cloud.com>
Cc:     Mike Kravetz <mike.kravetz@...cle.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linux Memory Management List <linux-mm@...ck.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] hugetlb: Fix comments about avoiding atomic allocation
 of vmemmap pages

On Wed, Mar 16, 2022 at 11:16 AM luofei <luofei@...cloud.com> wrote:
>
> Since there is no longer an atomic allocation of vmemmap pages,
> but a fixed flag(GFP_KERNEL | __GFP_NORETRY | __GFP_THISNODE) is
> used. The description of atomicity here is some what inappropriate.
>
> And the atomic parameter naming of update_and_free_page() may
> be misleading, add a comment here.
>
> Signed-off-by: luofei <luofei@...cloud.com>

Reviewed-by: Muchun Song <songmuchun@...edance.com>

Thanks.