linux-kernel - RE: [PATCH -next] media: amphion: Add missing of_node_put() in vpu_core_parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AM6PR04MB63419CD129367B8F2C811DF3E7119@AM6PR04MB6341.eurprd04.prod.outlook.com>
Date:   Wed, 16 Mar 2022 08:56:07 +0000
From:   Ming Qian <ming.qian@....com>
To:     Xiongfeng Wang <wangxiongfeng2@...wei.com>,
        Shijie Qin <shijie.qin@....com>,
        Eagle Zhou <eagle.zhou@....com>,
        "mchehab@...nel.org" <mchehab@...nel.org>
CC:     "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH -next] media: amphion: Add missing of_node_put() in
 vpu_core_parse_dt()

Hi Xiongfeng,

    Lijun Fang has sent a patch to fix this issue.
See link https://patchwork.linuxtv.org/project/linux-media/patch/20220314060952.66762-1-fanglijun3@huawei.com/

Ming

> From: Xiongfeng Wang [mailto:wangxiongfeng2@...wei.com]
> Sent: Wednesday, March 16, 2022 4:20 PM
> To: Ming Qian <ming.qian@....com>; Shijie Qin <shijie.qin@....com>; Eagle
> Zhou <eagle.zhou@....com>; mchehab@...nel.org
> Cc: linux-media@...r.kernel.org; linux-kernel@...r.kernel.org;
> wangxiongfeng2@...wei.com
> Subject: [PATCH -next] media: amphion: Add missing of_node_put() in
> vpu_core_parse_dt()
> 
> of_parse_phandle() will increment the refcount of the returned device_node.
> Calling of_node_put() to avoid the refcount leak.
> 
> Signed-off-by: Xiongfeng Wang <wangxiongfeng2@...wei.com>
> ---
>  drivers/media/platform/amphion/vpu_core.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/media/platform/amphion/vpu_core.c
> b/drivers/media/platform/amphion/vpu_core.c
> index 016554387f3f..1da20335bc45 100644
> --- a/drivers/media/platform/amphion/vpu_core.c
> +++ b/drivers/media/platform/amphion/vpu_core.c
> @@ -529,11 +529,14 @@ static int vpu_core_parse_dt(struct vpu_core *core,
> struct device_node *np)
>  	}
>  	if (of_address_to_resource(node, 0, &res)) {
>  		dev_err(core->dev, "boot-region of_address_to_resource error\n");
> +		of_node_put(node);
>  		return -EINVAL;
>  	}
>  	core->fw.phys = res.start;
>  	core->fw.length = resource_size(&res);
> 
> +	of_node_put(node);
> +
>  	node = of_parse_phandle(np, "memory-region", 1);
>  	if (!node) {
>  		dev_err(core->dev, "rpc-region of_parse_phandle error\n"); @@
> -541,6 +544,7 @@ static int vpu_core_parse_dt(struct vpu_core *core, struct
> device_node *np)
>  	}
>  	if (of_address_to_resource(node, 0, &res)) {
>  		dev_err(core->dev, "rpc-region of_address_to_resource error\n");
> +		of_node_put(node);
>  		return -EINVAL;
>  	}
>  	core->rpc.phys = res.start;
> @@ -549,6 +553,7 @@ static int vpu_core_parse_dt(struct vpu_core *core,
> struct device_node *np)
>  	if (core->rpc.length < core->res->rpc_size + core->res->fwlog_size) {
>  		dev_err(core->dev, "the rpc-region <%pad, 0x%x> is not enough\n",
>  			&core->rpc.phys, core->rpc.length);
> +		of_node_put(node);
>  		return -EINVAL;
>  	}
> 
> @@ -560,6 +565,7 @@ static int vpu_core_parse_dt(struct vpu_core *core,
> struct device_node *np)
>  	if (ret != VPU_CORE_MEMORY_UNCACHED) {
>  		dev_err(core->dev, "rpc region<%pad, 0x%x> isn't uncached\n",
>  			&core->rpc.phys, core->rpc.length);
> +		of_node_put(node);
>  		return -EINVAL;
>  	}
> 
> @@ -571,6 +577,8 @@ static int vpu_core_parse_dt(struct vpu_core *core,
> struct device_node *np)
>  	core->act.length = core->rpc.length - core->res->rpc_size -
> core->log.length;
>  	core->rpc.length = core->res->rpc_size;
> 
> +	of_node_put(node);
> +
>  	return 0;
>  }
> 
> --
> 2.20.1