linux-kernel - [tip: x86/cleanups] x86/nmi: Remove the 'strange power saving mode' hint from unknown NMI handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <164742580521.16921.12855276450839401894.tip-bot2@tip-bot2>
Date:   Wed, 16 Mar 2022 10:16:45 -0000
From:   "tip-bot2 for Jiri Kosina" <tip-bot2@...utronix.de>
To:     linux-tip-commits@...r.kernel.org
Cc:     Jiri Kosina <jkosina@...e.cz>, Borislav Petkov <bp@...e.de>,
        "Peter Zijlstra (Intel)" <peterz@...radead.org>, x86@...nel.org,
        linux-kernel@...r.kernel.org
Subject: [tip: x86/cleanups] x86/nmi: Remove the 'strange power saving mode'
 hint from unknown NMI handler

The following commit has been merged into the x86/cleanups branch of tip:

Commit-ID:     d4c9df20a37d128f6acb3c6286db7e694554a51b
Gitweb:        https://git.kernel.org/tip/d4c9df20a37d128f6acb3c6286db7e694554a51b
Author:        Jiri Kosina <jkosina@...e.cz>
AuthorDate:    Mon, 14 Mar 2022 09:25:18 +01:00
Committer:     Borislav Petkov <bp@...e.de>
CommitterDate: Wed, 16 Mar 2022 11:02:41 +01:00

x86/nmi: Remove the 'strange power saving mode' hint from unknown NMI handler

The

  Do you have a strange power saving mode enabled?

hint when unknown NMI happens dates back to i386 stone age, and isn't
currently really helpful.

Unknown NMIs are coming for many different reasons (broken firmware,
faulty hardware, ...) and rarely have anything to do with 'strange power
saving mode' (whatever that even is).

Just remove it as it's largerly misleading.

Signed-off-by: Jiri Kosina <jkosina@...e.cz>
Signed-off-by: Borislav Petkov <bp@...e.de>
Acked-by: Peter Zijlstra (Intel) <peterz@...radead.org>
Link: https://lore.kernel.org/r/nycvar.YFH.7.76.2203140924120.24795@cbobk.fhfr.pm
---
 arch/x86/kernel/nmi.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/x86/kernel/nmi.c b/arch/x86/kernel/nmi.c
index 4bce802..e73f7df 100644
--- a/arch/x86/kernel/nmi.c
+++ b/arch/x86/kernel/nmi.c
@@ -292,7 +292,6 @@ unknown_nmi_error(unsigned char reason, struct pt_regs *regs)
 	pr_emerg("Uhhuh. NMI received for unknown reason %02x on CPU %d.\n",
 		 reason, smp_processor_id());
 
-	pr_emerg("Do you have a strange power saving mode enabled?\n");
 	if (unknown_nmi_panic || panic_on_unrecovered_nmi)
 		nmi_panic(regs, "NMI: Not continuing");