lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20220316103834.GE1841@kadam>
Date:   Wed, 16 Mar 2022 13:38:34 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Pali Rohár <pali@...nel.org>
Cc:     Colin Ian King <colin.i.king@...il.com>,
        Sebastian Reichel <sre@...nel.org>, linux-pm@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] power: supply: bq2415x: Fix spelling mistake "vender" ->
 "vendor"

On Wed, Mar 16, 2022 at 01:35:26PM +0300, Dan Carpenter wrote:
> On Tue, Mar 15, 2022 at 11:46:45PM +0100, Pali Rohár wrote:
> > On Tuesday 15 March 2022 22:37:00 Colin Ian King wrote:
> > > There are several spelling mistakes in comments, function names
> > > and literal strings. Fix these.
> > 
> > I do not think that there are mistakes.
> > 
> > Please look at page 29 of the official bq24150 datasheet:
> > https://www.ti.com/lit/ds/symlink/bq24150.pdf
> > 
> 
> "Table 8. Vender/Part/Revision Register (Read only)"
> 
> Just because they spelled it wrong in the hardware spec doesn't mean we
> have to spell it wrong here.

Of course, there are times where spelling mistakes do have to be
preserved forever.  I forget the examples.  But here I think it's fine
to correct them.

regards,
dan carpenter

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ