linux-kernel - Re: [PATCH v4] staging: greybus: introduce pwm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e3567bf5-242d-ecdc-2a51-22c4d7d6f356@189.cn>
Date:   Wed, 16 Mar 2022 09:35:26 +0800
From:   Song Chen <chensong_2000@....cn>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     johan@...nel.org, elder@...nel.org, thierry.reding@...il.com,
        u.kleine-koenig@...gutronix.de, lee.jones@...aro.org,
        greybus-dev@...ts.linaro.org, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org, linux-pwm@...r.kernel.org,
        elder@...e.org
Subject: Re: [PATCH v4] staging: greybus: introduce pwm_ops::apply



在 2022/3/14 23:03, Greg KH 写道:
> On Wed, Mar 09, 2022 at 09:59:34AM +0800, Song Chen wrote:
>> Introduce newer .apply function in pwm_ops to
>> replace legacy operations,like enable, disable,
>> config and set_polarity.
> 
> You can use the full 72 columns please.

will do.

> 
>> This guarantees atomic changes of the pwm
>> controller configuration and also reduces the
>> size of the driver.
> 
> The driver is bigger (more lines) with this change, so why do you say it
> is smaller?

ohh, yes, you are right. I copied from another commit with similar 
function and didn't count lines carefully.

i will amend the commit message and submit a new one, many thanks.

> 
> thanks,
> 
> greg k-h
> 

BR

Song