linux-kernel - Re: [PATCH 0/3] Move FPU related code from DCN3.1x drivers to DML folder

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f1f242ca-4701-9352-7a88-38c546f3cabe@amd.com>
Date:   Wed, 16 Mar 2022 08:49:33 -0400
From:   Rodrigo Siqueira Jordao <rjordrigo@....com>
To:     Melissa Wen <mwen@...lia.com>, amd-gfx@...ts.freedesktop.org,
        dri-devel@...ts.freedesktop.org, airlied@...ux.ie,
        alexander.deucher@....com, christian.koenig@....com,
        daniel@...ll.ch, harry.wentland@....com, Rodrigo.Siqueira@....com,
        sunpeng.li@....com, Xinhui.Pan@....com
Cc:     Qingqing Zhuo <qingqing.zhuo@....com>,
        Dmytro Laktyushkin <Dmytro.Laktyushkin@....com>,
        linux-kernel@...r.kernel.org, Jasdeep Dhillon <jdhillon@....com>
Subject: Re: [PATCH 0/3] Move FPU related code from DCN3.1x drivers to DML
 folder



On 2022-03-07 10:47, Melissa Wen wrote:
> This series moves FPU code from DCN 3.1x drivers to dml/dcn31 folder to
> isolate FPU operations. For this, it creates dcn31_fpu files to centralize
> FPU operations and structs from dcn31x drivers, that include:
> - _vcs_dpi_ip_params_st and _vcs_dpi_soc_bounding_box_st structs
> - dcn31x_update_bw_bounding_box() functions
> - dcn31_calculate_wm_and_dlg_fp()
> 
> Also, it adds dc_assert_fp_enabled() in public dml-fpu functions, as required,
> and I've checked if their calls are properly wrapped by DC_FP_START/END (and
> removed when inside dml/fpu files too).
> 
> Melissa Wen (3):
>    drm/amd/dicplay: move FPU related code from dcn31 to dml/dcn31 folder
>    drm/amd/display: move FPU related code from dcn315 to dml/dcn31 folder
>    drm/amd/display: move FPU related code from dcn316 to dml/dcn31 folder
> 
>   drivers/gpu/drm/amd/display/dc/dcn31/Makefile |  26 -
>   .../drm/amd/display/dc/dcn31/dcn31_resource.c | 355 +------
>   .../drm/amd/display/dc/dcn31/dcn31_resource.h |   4 +-
>   .../gpu/drm/amd/display/dc/dcn315/Makefile    |  26 -
>   .../amd/display/dc/dcn315/dcn315_resource.c   | 232 +----
>   .../amd/display/dc/dcn315/dcn315_resource.h   |   3 +
>   .../gpu/drm/amd/display/dc/dcn316/Makefile    |  26 -
>   .../amd/display/dc/dcn316/dcn316_resource.c   | 231 +----
>   .../amd/display/dc/dcn316/dcn316_resource.h   |   3 +
>   drivers/gpu/drm/amd/display/dc/dml/Makefile   |   2 +
>   .../drm/amd/display/dc/dml/dcn31/dcn31_fpu.c  | 863 ++++++++++++++++++
>   .../drm/amd/display/dc/dml/dcn31/dcn31_fpu.h  |  44 +
>   12 files changed, 921 insertions(+), 894 deletions(-)
>   create mode 100644 drivers/gpu/drm/amd/display/dc/dml/dcn31/dcn31_fpu.c
>   create mode 100644 drivers/gpu/drm/amd/display/dc/dml/dcn31/dcn31_fpu.h
> 

Hi Melissa,

Thanks a lot for your patchset. We have already tested it with IGT, and 
we are running some manual tests to ensure that everything is fine. We 
will include your patch in this week's DC upstream, and if everything is 
alright, we will merge it next Monday.