linux-kernel - Re: [PATCH -next] ptrace: Remove duplicated include in ptrace.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 16 Mar 2022 08:35:59 -0500
From:   "Eric W. Biederman" <ebiederm@...ssion.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Yang Li <yang.lee@...ux.alibaba.com>,
        Oleg Nesterov <oleg@...hat.com>,
        linux-m68k <linux-m68k@...ts.linux-m68k.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH -next] ptrace: Remove duplicated include in ptrace.c

Geert Uytterhoeven <geert@...ux-m68k.org> writes:

> Hi Yang,
>
> CC Eric
>
> On Wed, Mar 16, 2022 at 12:52 AM Yang Li <yang.lee@...ux.alibaba.com> wrote:
>> Fix following includecheck warning:
>> ./arch/m68k/kernel/ptrace.c: linux/ptrace.h is included more than once.
>>
>> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
>> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>
>
> Thanks for your patch!
>
> Reviewed-by: Geert Uytterhoeven <geert@...ux-m68k.org>
>
>> --- a/arch/m68k/kernel/ptrace.c
>> +++ b/arch/m68k/kernel/ptrace.c
>> @@ -19,7 +19,6 @@
>>  #include <linux/ptrace.h>
>>  #include <linux/user.h>
>>  #include <linux/signal.h>
>> -#include <linux/ptrace.h>
>>
>>  #include <linux/uaccess.h>
>>  #include <asm/page.h>
>
> This is due to commit 153474ba1a4aed0a ("ptrace: Create
> ptrace_report_syscall_{entry,exit} in ptrace.h"), which is not yet
> in the m68k tree, but only in next-20220315, so I cannot do anything
> about it before v5.18-rc1.
>
> Eric: Can you still fix this in the original commit?

Not unless it is something very serious.  Replacing the commit means invalidating
testing and review.  Which I would rather not do.

In this case I can merge a trivial fix to remove the duplicate.  Let me
find Lang Li's patch and merge that.

Eric