linux-kernel - Re: [PATCH v2] scsi: core: Fix sbitmap depth in scsi_realloc_sdev_budget

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c3c7aefc-8d0b-b23a-8b9f-012f6ca8f8e4@acm.org>
Date:   Wed, 16 Mar 2022 07:29:23 -0700
From:   Bart Van Assche <bvanassche@....org>
To:     John Garry <john.garry@...wei.com>, jejb@...ux.ibm.com,
        martin.petersen@...cle.com
Cc:     damien.lemoal@...nsource.wdc.com, linux-kernel@...r.kernel.org,
        linux-scsi@...r.kernel.org, martin.wilck@...e.com,
        ming.lei@...hat.com, hch@....de, hare@...e.de
Subject: Re: [PATCH v2] scsi: core: Fix sbitmap depth in
 scsi_realloc_sdev_budget_map()

On 3/16/22 02:44, John Garry wrote:
> In commit edb854a3680b ("scsi: core: Reallocate device's budget map on
> queue depth change"), the sbitmap for the device budget map may be
> reallocated after the slave device depth is configured.
> 
> When the sbitmap is reallocated we use the result from
> scsi_device_max_queue_depth() for the sbitmap size, but don't resize to
> match the actual device queue depth.
> 
> Fix by resizing the sbitmap after reallocating the budget sbitmap. We do
> this instead of init'ing the sbitmap to the device queue depth as the user
> may want to change the queue depth later via sysfs or other.

Reviewed-by: Bart Van Assche <bvanassche@....org>