linux-kernel - Re: [PATCH v3] livepatch: Don't block removal of patches that are safe to unload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LSU.2.21.2203161602490.6444@pobox.suse.cz>
Date:   Wed, 16 Mar 2022 16:03:54 +0100 (CET)
From:   Miroslav Benes <mbenes@...e.cz>
To:     Petr Mladek <pmladek@...e.com>
cc:     Chengming Zhou <zhouchengming@...edance.com>, jpoimboe@...hat.com,
        jikos@...nel.org, joe.lawrence@...hat.com,
        live-patching@...r.kernel.org, linux-kernel@...r.kernel.org,
        songmuchun@...edance.com, qirui.001@...edance.com
Subject: Re: [PATCH v3] livepatch: Don't block removal of patches that are
 safe to unload

> > > + /*
> > > +	 * Only need to set forced flag for the transition patch
> > > +	 * when force transition to KLP_UNPATCHED state, but
> > > +	 * have to set forced flag for all replaced patches
> > > +	 * when force atomic replace transition.
> > > +	 */
> > 
> > How about something like
> > 
> > /*
> >  * Set forced flag for patches being removed, which is the transition
> >  * patch in KLP_UNPATCHED state or all replaced patches when forcing
> >  * the atomic replace transition.
> >  */
> 
> Or just the first sentence:
> 
> 	/* Set forced flag for patches being removed */
> 
> The rest is visible from the code.

True. This would work for me as well.

Miroslav