linux-kernel - Re: [PATCH] phy: ti: omap-usb2: Fix error handling in omap_usb2_enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YjIC1hWuVN3qkdqx@shaak>
Date:   Wed, 16 Mar 2022 11:31:34 -0400
From:   Liam Beguin <liambeguin@...il.com>
To:     Miaoqian Lin <linmq006@...il.com>
Cc:     Kishon Vijay Abraham I <kishon@...com>,
        Vinod Koul <vkoul@...nel.org>, Roger Quadros <rogerq@...com>,
        linux-phy@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] phy: ti: omap-usb2: Fix error handling in
 omap_usb2_enable_clocks

On Wed, Mar 16, 2022 at 02:41:53AM +0000, Miaoqian Lin wrote:
> The corresponding API for clk_prepare_enable is clk_disable_unprepare,
> other than clk_disable_unprepare.
> 
> Fix this by changing clk_disable to clk_disable_unprepare.

There seems to be a typo in the first sentence of the commit message.
Maybe something like this would do:

	The corresponding API for clk_prepare_enable is clk_disable_unprepare.
	Make sure that the clock is unprepared on exit by changing clk_disable
	to clk_disable_unprepare.

> 
> Fixes: ed31ee7cf1fe ("phy: ti: usb2: Fix logic on -EPROBE_DEFER")
> Signed-off-by: Miaoqian Lin <linmq006@...il.com>

Other than that,

Reviewed-by: Liam Beguin <liambeguin@...il.com>

> ---
>  drivers/phy/ti/phy-omap-usb2.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/phy/ti/phy-omap-usb2.c b/drivers/phy/ti/phy-omap-usb2.c
> index 3a505fe5715a..31a775877f6e 100644
> --- a/drivers/phy/ti/phy-omap-usb2.c
> +++ b/drivers/phy/ti/phy-omap-usb2.c
> @@ -215,7 +215,7 @@ static int omap_usb2_enable_clocks(struct omap_usb *phy)
>  	return 0;
>  
>  err1:
> -	clk_disable(phy->wkupclk);
> +	clk_disable_unprepare(phy->wkupclk);
>  
>  err0:
>  	return ret;
> -- 
> 2.17.1
>