linux-kernel - Re: [PATCH 3/3] clocksource: arch_timer: Add arm,cortex-a7/15-timer in of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f54b0647-12ad-5861-8b8b-5d4233bb9bd2@canonical.com>
Date:   Wed, 16 Mar 2022 17:30:26 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
To:     Kuldeep Singh <singh.kuldeep87k@...il.com>,
        Marc Zyngier <marc.zyngier@....com>,
        Mark Rutland <mark.rutland@....com>,
        Marc Zyngier <maz@...nel.org>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Thomas Gleixner <tglx@...utronix.de>
Cc:     linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH 3/3] clocksource: arch_timer: Add arm,cortex-a7/15-timer
 in of_match list

On 16/03/2022 10:54, Kuldeep Singh wrote:
> Few platforms such as Renesas RZ/N1D, Calxeda, Alpine etc. are using
> arm,cortex-a15-timer and arm,cortex-a7-timer entries in conjugation with
> arm,armv7-timer which are not currently defined in driver file. Add
> these entries in arch_timer_of_match list to bring them in use.
> 

This looks wrong (also Marc pointed this out) and rationale is not
sufficient. Why do you need these compatibles in the driver?

Best regards,
Krzysztof