linux-kernel - Re: [PATCH v2] nfsd: use correct format characters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1F848996-D3E8-45A2-92E0-52939974B143@oracle.com>
Date:   Thu, 17 Mar 2022 19:02:09 +0000
From:   Chuck Lever III <chuck.lever@...cle.com>
To:     Thomas Haynes <loghyr@...il.com>
CC:     Nathan Chancellor <nathan@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Linux NFS Mailing List <linux-nfs@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "llvm@...ts.linux.dev" <llvm@...ts.linux.dev>,
        Bill Wendling <morbo@...gle.com>
Subject: Re: [PATCH v2] nfsd: use correct format characters



> On Mar 17, 2022, at 2:42 PM, Bill Wendling <morbo@...gle.com> wrote:
> 
> When compiling with -Wformat, clang emits the following warnings:
> 
> fs/nfsd/flexfilelayout.c:120:27: warning: format specifies type 'unsigned
> char' but the argument has type 'int' [-Wformat]
>                         "%s.%hhu.%hhu", addr, port >> 8, port & 0xff);
>                             ~~~~              ^~~~~~~~~
>                             %d
> fs/nfsd/flexfilelayout.c:120:38: warning: format specifies type 'unsigned
> char' but the argument has type 'int' [-Wformat]
>                         "%s.%hhu.%hhu", addr, port >> 8, port & 0xff);
>                                  ~~~~                    ^~~~~~~~~~~
>                                  %d
> 
> The types of these arguments are unconditionally defined, so this patch
> updates the format character to the correct ones for ints and unsigned
> ints.
> 
> Link: https://github.com/ClangBuiltLinux/linux/issues/378
> Signed-off-by: Bill Wendling <morbo@...gle.com>
> ---
> v2 - Fixed "Link" to be a valid URL.

Hi Tom, can I get a Reviewed-by from you?


> ---
> fs/nfsd/flexfilelayout.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/nfsd/flexfilelayout.c b/fs/nfsd/flexfilelayout.c
> index 2e2f1d5e9f62..070f90ed09b6 100644
> --- a/fs/nfsd/flexfilelayout.c
> +++ b/fs/nfsd/flexfilelayout.c
> @@ -117,7 +117,7 @@ nfsd4_ff_proc_getdeviceinfo(struct super_block *sb, struct svc_rqst *rqstp,
> 
> 	da->netaddr.addr_len =
> 		snprintf(da->netaddr.addr, FF_ADDR_LEN + 1,
> -			 "%s.%hhu.%hhu", addr, port >> 8, port & 0xff);
> +			 "%s.%d.%d", addr, port >> 8, port & 0xff);
> 
> 	da->tightly_coupled = false;
> 
> -- 
> 2.35.1.723.g4982287a31-goog
> 

--
Chuck Lever