linux-kernel - Re: [PATCHv6 15/30] x86/boot: Port I/O: allow to hook up alternative helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c3b640aa-05a1-7706-0c0f-b3f75eee58c6@intel.com>
Date:   Thu, 17 Mar 2022 13:20:07 -0700
From:   Dave Hansen <dave.hansen@...el.com>
To:     "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
        Thomas Gleixner <tglx@...utronix.de>
Cc:     mingo@...hat.com, bp@...en8.de, luto@...nel.org,
        peterz@...radead.org, sathyanarayanan.kuppuswamy@...ux.intel.com,
        aarcange@...hat.com, ak@...ux.intel.com, dan.j.williams@...el.com,
        david@...hat.com, hpa@...or.com, jgross@...e.com,
        jmattson@...gle.com, joro@...tes.org, jpoimboe@...hat.com,
        knsathya@...nel.org, pbonzini@...hat.com, sdeep@...are.com,
        seanjc@...gle.com, tony.luck@...el.com, vkuznets@...hat.com,
        wanpengli@...cent.com, thomas.lendacky@....com,
        brijesh.singh@....com, x86@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCHv6 15/30] x86/boot: Port I/O: allow to hook up alternative
 helpers

On 3/17/22 13:10, Kirill A. Shutemov wrote:
>> Hmm?
> This kind of initializations are problematic. They generate run-time
> relacations that kernel cannot handle in the boot stub. Linker complains
> about this:
> 
> 	ld.lld: error: Unexpected run-time relocations (.rela) detected!
> 
> I will leave it as is, unless you have better ideas.

Right now you've got:

	#define inb pio_ops.inb

You keep the preprocessor away from things like

	foo.inb = bar;

with:

	#define inb(x) pio_ops.inb(x)