linux-kernel - RE: [PATCH 1/2] pahole: avoid segfault when parsing bogus file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6232c04f3c9d2_487f20860@john.notmuch>
Date:   Wed, 16 Mar 2022 21:59:59 -0700
From:   John Fastabend <john.fastabend@...il.com>
To:     kkourt@...urt.io, Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:     dwarves@...r.kernel.org, bpf@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Kornilios Kourtis <kornilios@...valent.com>
Subject: RE: [PATCH 1/2] pahole: avoid segfault when parsing bogus file

kkourt@ wrote:
> From: Kornilios Kourtis <kornilios@...valent.com>
> 
> When trying to use btf encoding for an apparently problematic kernel
> file, pahole segfaults. As can be seen below [1], the problem is that we
> are trying to dereference a NULL decoder.
> 
> Fix this by checking the return value of dwfl_getmodules which [2] whill
> return -1 on errors or an offset if one of the modules did not return
> DWARF_CB_OK. (In this specific case, it was __cus__load_debug_types that
> returned DWARF_CB_ABORT.)
> 

[...]
 
> [2] https://sourceware.org/git/?p=elfutils.git;a=blob;f=libdwfl/libdwfl.h;h=f98f1d525d94bc7bcfc7c816890de5907ee4bd6d;hb=HEAD#l200

Thanks for the reference and fix.

Acked-by: John Fastabend <john.fastabend@...il.com>