lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 17 Mar 2022 11:52:32 +0800 From: Yu Liao <liaoyu15@...wei.com> To: <linux-kernel@...r.kernel.org> CC: <manivannan.sadhasivam@...aro.org>, <liwei391@...wei.com> Subject: Re: [PATCH -next] bus: mhi: ep: remove useless judgement in mhi_ep_ring_add_element Hi Manivannan, I found that 'ret = ' has been removed. If this is intentional, the check of 'ret' is redundant. Thanks, Yu On 2022/3/17 11:31, Yu Liao wrote: > Remove the check of 'ret' that is impossible to be non-zero. > > Signed-off-by: Yu Liao <liaoyu15@...wei.com> > --- > drivers/bus/mhi/ep/ring.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/bus/mhi/ep/ring.c b/drivers/bus/mhi/ep/ring.c > index ac2043e71943..161505cd628f 100644 > --- a/drivers/bus/mhi/ep/ring.c > +++ b/drivers/bus/mhi/ep/ring.c > @@ -131,8 +131,6 @@ int mhi_ep_ring_add_element(struct mhi_ep_ring *ring, struct mhi_ring_element *e > > mhi_cntrl->write_to_host(mhi_cntrl, (void __iomem *)el, ring->rbase + (old_offset * > sizeof(*el)), sizeof(*el)); > - if (ret < 0) > - return ret; > > return 0; > }
Powered by blists - more mailing lists