linux-kernel - RE: [PATCH v4 14/32] iommu: introduce iommu_domain_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BN9PR11MB5276360F6DBDC3A238F3E41A8C129@BN9PR11MB5276.namprd11.prod.outlook.com>
Date:   Thu, 17 Mar 2022 05:47:36 +0000
From:   "Tian, Kevin" <kevin.tian@...el.com>
To:     Robin Murphy <robin.murphy@....com>,
        Matthew Rosato <mjrosato@...ux.ibm.com>,
        "linux-s390@...r.kernel.org" <linux-s390@...r.kernel.org>
CC:     "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "david@...hat.com" <david@...hat.com>,
        "farman@...ux.ibm.com" <farman@...ux.ibm.com>,
        "oberpar@...ux.ibm.com" <oberpar@...ux.ibm.com>,
        "vneethv@...ux.ibm.com" <vneethv@...ux.ibm.com>,
        "agordeev@...ux.ibm.com" <agordeev@...ux.ibm.com>,
        "imbrenda@...ux.ibm.com" <imbrenda@...ux.ibm.com>,
        "will@...nel.org" <will@...nel.org>,
        Jean-Philippe Brucker <jean-philippe@...aro.org>,
        "frankja@...ux.ibm.com" <frankja@...ux.ibm.com>,
        "corbet@....net" <corbet@....net>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
        "pasic@...ux.ibm.com" <pasic@...ux.ibm.com>,
        "jgg@...dia.com" <jgg@...dia.com>,
        "gerald.schaefer@...ux.ibm.com" <gerald.schaefer@...ux.ibm.com>,
        "borntraeger@...ux.ibm.com" <borntraeger@...ux.ibm.com>,
        "thuth@...hat.com" <thuth@...hat.com>,
        "gor@...ux.ibm.com" <gor@...ux.ibm.com>,
        "schnelle@...ux.ibm.com" <schnelle@...ux.ibm.com>,
        "hca@...ux.ibm.com" <hca@...ux.ibm.com>,
        "alex.williamson@...hat.com" <alex.williamson@...hat.com>,
        "freude@...ux.ibm.com" <freude@...ux.ibm.com>,
        "pmorel@...ux.ibm.com" <pmorel@...ux.ibm.com>,
        "cohuck@...hat.com" <cohuck@...hat.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "iommu@...ts.linux-foundation.org" <iommu@...ts.linux-foundation.org>,
        "svens@...ux.ibm.com" <svens@...ux.ibm.com>,
        "pbonzini@...hat.com" <pbonzini@...hat.com>,
        "Zhao, Yan Y" <yan.y.zhao@...el.com>
Subject: RE: [PATCH v4 14/32] iommu: introduce iommu_domain_alloc_type and the
 KVM type

> From: Robin Murphy
> Sent: Tuesday, March 15, 2022 6:49 PM
> 
> On 2022-03-14 19:44, Matthew Rosato wrote:
> > s390x will introduce an additional domain type that is used for
> > managing IOMMU owned by KVM.  Define the type here and add an
> > interface for allocating a specified type vs the default type.
> 
> I'm also not a huge fan of adding a new domain_alloc interface like
> this, however if it is justifiable, then please make it take struct
> device rather than struct bus_type as an argument.
> 
> It also sounds like there may be a degree of conceptual overlap here
> with what Jean-Philippe is working on for sharing pagetables between KVM
> and SMMU for Android pKVM, so it's probably worth some thought over
> whether there's any scope for common interfaces in terms of actual
> implementation.
> 

Same here. Yan Zhao is working on page table sharing between KVM
and VT-d. This is one important usage to build atop iommufd and
a set of common interfaces are definitely necessary here. 😊

Thanks
Kevin