| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <5db1feea-f630-79e6-15cc-77babf58a429@infradead.org>
Date: Wed, 16 Mar 2022 21:59:01 -0700
From: Randy Dunlap <rdunlap@...radead.org>
To: Ira Weiny <ira.weiny@...el.com>
Cc: linux-kernel@...r.kernel.org,
"Michael S. Tsirkin" <mst@...hat.com>,
Jason Wang <jasowang@...hat.com>,
Paolo Bonzini <pbonzini@...hat.com>,
Stefan Hajnoczi <stefanha@...hat.com>,
Jens Axboe <axboe@...nel.dk>, Amit Shah <amit@...nel.org>,
Arnd Bergmann <arnd@...db.de>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Eli Cohen <eli@...lanox.com>,
Saeed Mahameed <saeedm@...dia.com>,
Leon Romanovsky <leon@...nel.org>,
Pablo Neira Ayuso <pablo@...filter.org>,
Jozsef Kadlecsik <kadlec@...filter.org>,
Florian Westphal <fw@...len.de>,
"David S. Miller" <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>,
"James E.J. Bottomley" <jejb@...ux.ibm.com>,
"Martin K. Petersen" <martin.petersen@...cle.com>,
Michał Mirosław <mirq-linux@...e.qmqm.pl>,
Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
Krzysztof Opasiak <k.opasiak@...sung.com>,
Igor Kotrasinski <i.kotrasinsk@...sung.com>,
Valentina Manea <valentina.manea.m@...il.com>,
Shuah Khan <shuah@...nel.org>,
Shuah Khan <skhan@...uxfoundation.org>,
Jussi Kivilinna <jussi.kivilinna@...et.fi>,
Joachim Fritschi <jfritschi@...enet.de>,
Herbert Xu <herbert@...dor.apana.org.au>,
Thomas Gleixner <tglx@...utronix.de>,
Steven Rostedt <rostedt@...dmis.org>,
Ingo Molnar <mingo@...nel.org>,
Karol Herbst <karolherbst@...il.com>,
Pekka Paalanen <ppaalanen@...il.com>,
Dave Hansen <dave.hansen@...ux.intel.com>,
Andy Lutomirski <luto@...nel.org>,
Peter Zijlstra <peterz@...radead.org>,
Borislav Petkov <bp@...en8.de>,
"H. Peter Anvin" <hpa@...or.com>, netfilter-devel@...r.kernel.org,
coreteam@...filter.org, netdev@...r.kernel.org,
linux-block@...r.kernel.org, linux-crypto@...r.kernel.org,
linux-rdma@...r.kernel.org, linux-scsi@...r.kernel.org,
linux-usb@...r.kernel.org, nouveau@...ts.freedesktop.org,
virtualization@...ts.linux-foundation.org, x86@...nel.org,
Felipe Balbi <balbi@...nel.org>
Subject: Re: [PATCH 6/9] usb: gadget: eliminate anonymous module_init &
module_exit
On 3/16/22 20:29, Ira Weiny wrote:
> On Wed, Mar 16, 2022 at 12:20:07PM -0700, Randy Dunlap wrote:
>> Eliminate anonymous module_init() and module_exit(), which can lead to
>> confusion or ambiguity when reading System.map, crashes/oops/bugs,
>> or an initcall_debug log.
>>
>> Give each of these init and exit functions unique driver-specific
>> names to eliminate the anonymous names.
>>
>> Example 1: (System.map)
>> ffffffff832fc78c t init
>> ffffffff832fc79e t init
>> ffffffff832fc8f8 t init
>>
>> Example 2: (initcall_debug log)
>> calling init+0x0/0x12 @ 1
>> initcall init+0x0/0x12 returned 0 after 15 usecs
>> calling init+0x0/0x60 @ 1
>> initcall init+0x0/0x60 returned 0 after 2 usecs
>> calling init+0x0/0x9a @ 1
>> initcall init+0x0/0x9a returned 0 after 74 usecs
>>
>> Fixes: bd25a14edb75 ("usb: gadget: legacy/serial: allow dynamic removal")
>> Fixes: 7bb5ea54be47 ("usb gadget serial: use composite gadget framework")
>> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
>
> I continue to be confused about the latest rules for the Fixes tag but this one
> in particular seems completely useless. This is the 'beginning of time' commit
> by Linus AFAICT. So do any of these Fixes tags need to be in this series?
I guess it mostly depends on whether they get applied to stable trees, but
it's entirely fine with me if they don't.
{I also corrected Felipe's email address here.}
> Regardless:
>
> Reviewed-by: Ira Weiny <ira.weiny@...el.com>
Thanks.
>
>> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
>> Cc: Felipe Balbi <felipe.balbi@...ux.intel.com>
>> Cc: Michał Mirosław <mirq-linux@...e.qmqm.pl>
>> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
>> Cc: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
>> Cc: linux-usb@...r.kernel.org
>> ---
>> drivers/usb/gadget/legacy/inode.c | 8 ++++----
>> drivers/usb/gadget/legacy/serial.c | 10 +++++-----
>> drivers/usb/gadget/udc/dummy_hcd.c | 8 ++++----
>> 3 files changed, 13 insertions(+), 13 deletions(-)
>>
>> --- lnx-517-rc8.orig/drivers/usb/gadget/legacy/serial.c
>> +++ lnx-517-rc8/drivers/usb/gadget/legacy/serial.c
>> @@ -273,7 +273,7 @@ static struct usb_composite_driver gseri
>> static int switch_gserial_enable(bool do_enable)
>> {
>> if (!serial_config_driver.label)
>> - /* init() was not called, yet */
>> + /* gserial_init() was not called, yet */
>> return 0;
>>
>> if (do_enable)
>> @@ -283,7 +283,7 @@ static int switch_gserial_enable(bool do
>> return 0;
>> }
>>
>> -static int __init init(void)
>> +static int __init gserial_init(void)
>> {
>> /* We *could* export two configs; that'd be much cleaner...
>> * but neither of these product IDs was defined that way.
>> @@ -314,11 +314,11 @@ static int __init init(void)
>>
>> return usb_composite_probe(&gserial_driver);
>> }
>> -module_init(init);
>> +module_init(gserial_init);
>>
>> -static void __exit cleanup(void)
>> +static void __exit gserial_cleanup(void)
>> {
>> if (enable)
>> usb_composite_unregister(&gserial_driver);
>> }
>> -module_exit(cleanup);
>> +module_exit(gserial_cleanup);
>> --- lnx-517-rc8.orig/drivers/usb/gadget/udc/dummy_hcd.c
>> +++ lnx-517-rc8/drivers/usb/gadget/udc/dummy_hcd.c
>> @@ -2765,7 +2765,7 @@ static struct platform_driver dummy_hcd_
>> static struct platform_device *the_udc_pdev[MAX_NUM_UDC];
>> static struct platform_device *the_hcd_pdev[MAX_NUM_UDC];
>>
>> -static int __init init(void)
>> +static int __init dummy_hcd_init(void)
>> {
>> int retval = -ENOMEM;
>> int i;
>> @@ -2887,9 +2887,9 @@ err_alloc_udc:
>> platform_device_put(the_hcd_pdev[i]);
>> return retval;
>> }
>> -module_init(init);
>> +module_init(dummy_hcd_init);
>>
>> -static void __exit cleanup(void)
>> +static void __exit dummy_hcd_cleanup(void)
>> {
>> int i;
>>
>> @@ -2905,4 +2905,4 @@ static void __exit cleanup(void)
>> platform_driver_unregister(&dummy_udc_driver);
>> platform_driver_unregister(&dummy_hcd_driver);
>> }
>> -module_exit(cleanup);
>> +module_exit(dummy_hcd_cleanup);
>> --- lnx-517-rc8.orig/drivers/usb/gadget/legacy/inode.c
>> +++ lnx-517-rc8/drivers/usb/gadget/legacy/inode.c
>> @@ -2101,7 +2101,7 @@ MODULE_ALIAS_FS("gadgetfs");
>>
>> /*----------------------------------------------------------------------*/
>>
>> -static int __init init (void)
>> +static int __init gadgetfs_init (void)
>> {
>> int status;
>>
>> @@ -2111,12 +2111,12 @@ static int __init init (void)
>> shortname, driver_desc);
>> return status;
>> }
>> -module_init (init);
>> +module_init (gadgetfs_init);
>>
>> -static void __exit cleanup (void)
>> +static void __exit gadgetfs_cleanup (void)
>> {
>> pr_debug ("unregister %s\n", shortname);
>> unregister_filesystem (&gadgetfs_type);
>> }
>> -module_exit (cleanup);
>> +module_exit (gadgetfs_cleanup);
>>
--
~Randy
Powered by blists - more mailing lists