linux-kernel - Re: [PATCH] ARM: JIVE: fix return value of _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cdba580f-097e-da4d-bfb4-63a7cb64ec95@kernel.org>
Date:   Thu, 17 Mar 2022 08:32:34 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Randy Dunlap <rdunlap@...radead.org>, linux-kernel@...r.kernel.org
Cc:     patches@...ts.linux.dev, Ben Dooks <ben-linux@...ff.org>,
        Alim Akhtar <alim.akhtar@...sung.com>,
        Russell King <linux@...linux.org.uk>,
        linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, patches@...linux.org.uk
Subject: Re: [PATCH] ARM: JIVE: fix return value of __setup handler

On 12/03/2022 07:36, Randy Dunlap wrote:
> __setup() handlers should return 1 to obsolete_checksetup() in
> init/main.c to indicate that the boot option has been handled.
> A return of 0 causes the boot option/value to be listed as an Unknown
> kernel parameter and added to init's (limited) argument or environment
> strings. Also, error return codes don't mean anything to
> obsolete_checksetup() -- only non-zero (usually 1) or zero.
> So return 1 from jive_mtdset().
> 
> Fixes: 9db829f485c5 ("[ARM] JIVE: Initial machine support for Logitech Jive")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Ben Dooks <ben-linux@...ff.org>
> Cc: Krzysztof Kozlowski <krzk@...nel.org>
> Cc: Alim Akhtar <alim.akhtar@...sung.com>
> Cc: Russell King <linux@...linux.org.uk>
> Cc: linux-arm-kernel@...ts.infradead.org
> Cc: linux-samsung-soc@...r.kernel.org
> Cc: patches@...linux.org.uk
> ---
> KernelVersion: v5.17-rc7
> 
>  arch/arm/mach-s3c/mach-jive.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 

It's too late for upcoming cycle, so I will pick it up after merge window.


Best regards,
Krzysztof