linux-kernel - Re: [PATCH] macintosh: smu: Fix warning comparing pointer to 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b679c9a8-dce7-d492-6c2d-c82cbbb6f903@csgroup.eu>
Date:   Thu, 17 Mar 2022 08:46:30 +0000
From:   Christophe Leroy <christophe.leroy@...roup.eu>
To:     Haowen Bai <baihaowen@...zu.com>,
        "benh@...nel.crashing.org" <benh@...nel.crashing.org>,
        "masahiroy@...nel.org" <masahiroy@...nel.org>,
        "adobriyan@...il.com" <adobriyan@...il.com>
CC:     "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] macintosh: smu: Fix warning comparing pointer to 0



Le 17/03/2022 à 03:44, Haowen Bai a écrit :
> Avoid pointer type value compared with 0 to make code clear.
> 
> Signed-off-by: Haowen Bai <baihaowen@...zu.com>

This change is already awaiting at 
https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20210825061838.69746-1-deng.changcheng@zte.com.cn/

Thanks
Christophe


> ---
>   drivers/macintosh/smu.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/macintosh/smu.c b/drivers/macintosh/smu.c
> index a4fbc3f..d72d073 100644
> --- a/drivers/macintosh/smu.c
> +++ b/drivers/macintosh/smu.c
> @@ -1087,7 +1087,7 @@ static int smu_open(struct inode *inode, struct file *file)
>   	unsigned long flags;
>   
>   	pp = kzalloc(sizeof(struct smu_private), GFP_KERNEL);
> -	if (pp == 0)
> +	if (!pp)
>   		return -ENOMEM;
>   	spin_lock_init(&pp->lock);
>   	pp->mode = smu_file_commands;
> @@ -1254,7 +1254,7 @@ static __poll_t smu_fpoll(struct file *file, poll_table *wait)
>   	__poll_t mask = 0;
>   	unsigned long flags;
>   
> -	if (pp == 0)
> +	if (!pp)
>   		return 0;
>   
>   	if (pp->mode == smu_file_commands) {
> @@ -1277,7 +1277,7 @@ static int smu_release(struct inode *inode, struct file *file)
>   	unsigned long flags;
>   	unsigned int busy;
>   
> -	if (pp == 0)
> +	if (!pp)
>   		return 0;
>   
>   	file->private_data = NULL;