linux-kernel - Re: [PATCH v9] block: cancel all throttled bios in del

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f46c8512-400b-144f-e2ba-c57cc895fca8@huawei.com>
Date:   Thu, 17 Mar 2022 19:22:04 +0800
From:   "yukuai (C)" <yukuai3@...wei.com>
To:     Ming Lei <ming.lei@...hat.com>
CC:     Christoph Hellwig <hch@...radead.org>, <tj@...nel.org>,
        <axboe@...nel.dk>, <cgroups@...r.kernel.org>,
        <linux-block@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <yi.zhang@...wei.com>
Subject: Re: [PATCH v9] block: cancel all throttled bios in del_gendisk()

在 2022/03/02 8:51, Ming Lei 写道:
> On Tue, Mar 01, 2022 at 09:54:28PM +0800, yukuai (C) wrote:
>> 在 2022/03/01 18:29, Ming Lei 写道:
>>> On Mon, Feb 28, 2022 at 01:40:53AM -0800, Christoph Hellwig wrote:
>>>> On Mon, Feb 28, 2022 at 02:11:30PM +0800, Ming Lei wrote:
>>>>>> FYI, this crashed left rigt and center when running xfstests with
>>>>>> traces pointing to throtl_pending_timer_fn.
>>>>>
>>>>> Can you share the exact xfstests test(fs, test)? Or panic log?
>>>>>
>>>>> I can't reproduce it when running './check -g auto' on XFS, meantime
>>>>> tracking throtl_pending_timer_fn().
>>>>
>>>>   From a quick run using f2fs:
>>>>
>>>> generic/081 files ... [  316.487861] run fstests generic/081 at 2022-02-28 09:38:40
>>>
>>> Thanks for providing the reproducer.
>>>
>>> The reason is that the pending timer is deleted in blkg's release
>>> handler, so the timer can still be live after request queue is released.
>>>
>>> The patch of 'block: cancel all throttled bios in del_gendisk()' should just
>>> make it easier to trigger.
>>>
>>> After patch of "block: move blkcg initialization/destroy into disk allocation/
>>> release handler" lands, the issue can be fixed easily by:

Hi, Ming

Now that the above patch is landed in linux-next, do you intend to fix
the above problem? Or I can take over if you don't mind.

Thanks,
Kuai