linux-kernel - [PATCH -next] binder: Fix some kernel-doc comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Thu, 17 Mar 2022 09:40:42 +0800
From:   Yang Li <yang.lee@...ux.alibaba.com>
To:     arve@...roid.com
Cc:     tkjos@...roid.com, maco@...roid.com, joel@...lfernandes.org,
        brauner@...nel.org, hridya@...gle.com, surenb@...gle.com,
        linux-kernel@...r.kernel.org, Yang Li <yang.lee@...ux.alibaba.com>,
        Abaci Robot <abaci@...ux.alibaba.com>
Subject: [PATCH -next] binder: Fix some kernel-doc comments

Remove some warnings found by running scripts/kernel-doc,
which is caused by using 'make W=1'.

drivers/android/binder.c:1155: warning: expecting prototype for
binder_dec_ref(). Prototype was for binder_dec_ref_olocked() instead
drivers/android/binder.c:2683: warning: Function parameter or member
'procp' not described in 'binder_get_node_refs_for_txn'
drivers/android/binder.c:2683: warning: Excess function parameter 'proc'
description in 'binder_get_node_refs_for_txn'

Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>
---
 drivers/android/binder.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/android/binder.c b/drivers/android/binder.c
index 8351c5638880..65e8145e6170 100644
--- a/drivers/android/binder.c
+++ b/drivers/android/binder.c
@@ -1143,7 +1143,7 @@ static int binder_inc_ref_olocked(struct binder_ref *ref, int strong,
 }
 
 /**
- * binder_dec_ref() - dec the ref for given handle
+ * binder_dec_ref_olocked() - dec the ref for given handle
  * @ref:	ref to be decremented
  * @strong:	if true, strong decrement, else weak
  *
@@ -2658,7 +2658,7 @@ static int binder_proc_transaction(struct binder_transaction *t,
 /**
  * binder_get_node_refs_for_txn() - Get required refs on node for txn
  * @node:         struct binder_node for which to get refs
- * @proc:         returns @node->proc if valid
+ * @procp:         returns @node->proc if valid
  * @error:        if no @proc then returns BR_DEAD_REPLY
  *
  * User-space normally keeps the node alive when creating a transaction
-- 
2.20.1.7.g153144c